Fix bad data in example deviation file #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inclination value provided (424) is outside of the normal inclination domain range which we expect to be 0 <= inc < 180. The neighbouring values of 4.87 and 4.42 suggest that the value of 424 should actually be 4.24 The corresponding test output value (987.03517) was also updated to 998.45378 to reflect the corrected inclination.
|
Seems like there should be a test containing some bad data? Maybe add a new file with one or more perturbations that we can then catch / warn about. |
|
Yes I agree I've added issue #157 so we can do that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclination value provided (424) is outside of the normal
inclination domain range which we expect to be 0 <= inc < 180.
The neighbouring values of 4.87 and 4.42 suggest that the
value of 424 should actually be 4.24
The corresponding test output value (987.03517) was also updated
to 998.45378 to reflect the corrected inclination.