Option for issue-126: Convert str to None for location.td in well.plot() #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution to pull-request #134 (issue #126 Resolve this issue at the most specific place it occurs in well.py):
Resolve this issue at the most specific place it occurs in well.py::plot():
The benefits of this solution are that it is seems simple and it is right at the location of the issue.
The drawbacks are that it clutters the processing code with data formatting code and that it might (but unlikely to) impact other code using self.location.td in other parts of the code. Initially I tried to stay away from this solution because applying this approach to many problems can fill an application with many local special cases rather than having a consistent way and central place for special case configuration. ... All that said, it is so simple to implement, and if this is a rare special case, it could be a good solution.
Changes:
The value of self.location.td is used to set the 'lower' variable which
must be either None or a number.
Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.
Thank you,
DC