Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AssertionError in test_project::test_project #135

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Fix AssertionError in test_project::test_project #135

merged 1 commit into from
Jul 30, 2020

Conversation

dcslagel
Copy link
Contributor

@dcslagel dcslagel commented Jul 29, 2020

This pull-request resolves the following error in the current test suite:
FAILED tests/test_project.py::test_project - AssertionError: assert '1' == 1
This issue exists on both the master and the develop branches.

It is evaluating assert project.uwis[0] which stores a str object.

coverage report after this change:

Name                      Stmts   Miss  Cover
---------------------------------------------
welly/__init__.py            16      2    88%
welly/_version.py             2      0   100%
welly/canstrat.py           102     23    77%
welly/canstrat_codes.py      23      0   100%
welly/crs.py                 49      7    86%
welly/curve.py              382    114    70%
welly/defaults.py             2      0   100%
welly/fields.py               2      0   100%
welly/header.py              30      8    73%
welly/location.py           153     58    62%
welly/project.py            353    198    44%
welly/quality.py             81     31    62%
welly/scales.py              56     22    61%
welly/synthetic.py           47      9    81%
welly/tools.py                7      1    86%
welly/utils.py              200     44    78%
welly/well.py               523    203    61%
---------------------------------------------
TOTAL                      2028    720    64%

Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.

Thank you,
DC

@kwinkunks kwinkunks merged commit 1769637 into agilescientific:develop Jul 30, 2020
@kwinkunks
Copy link
Member

Thank you! - Matt

@dcslagel dcslagel deleted the fix-test-project-assertion branch December 10, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants