Fix feature_names_in_ attribute for knn_transformer in exercise 4 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, self.feature_names_in_ was assigned to have the same value as self.estimator.feature_names_in_ but I think this is incorrect because self.estimator is not yet fitted. The fitted estimator is self.estimator_, so self_feature_names_in_ should be equal to self.estimator_.feature_names_in_. (Note the added _) Attempting to access knn_transformer.feature_names_in_ with the original code, would result in an error stating that the attribute doesn't exist, but with my change it outputs ['latitude', 'longitude'], which is the excpected output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, self.feature_names_in_ was assigned to have the same value as self.estimator.feature_names_in_ but I think this is incorrect because self.estimator is not yet fitted. The fitted estimator is self.estimator_, so self_feature_names_in_ should be equal to self.estimator_.feature_names_in_. (Note the added _)
Attempting to access knn_transformer.feature_names_in_ with the original code, would result in an error stating that the attribute doesn't exist, but with this small change it outputs ['latitude', 'longitude'], which is the excpected output