fix: tasks list has old wrong items and add switch for auto download torrent #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicarne
changed the title
agalwood
requested changes
Jun 15, 2021
There was a problem hiding this comment.
You need add follow-torrent and follow-metalink default value before 'listen-port' in ConfigManager.initSystemConfig()
Motrix/src/main/core/ConfigManager.js
Line 62 in 509c799
| @@ -168,7 +168,7 @@ | |||
| } | |||
| }) | |||
| merge(cached.files, result) | |||
|
|
|||
| cached.files.splice(result.length, cached.files.length - result.length) | |||
There was a problem hiding this comment.
Remove this line, and add follow codes before methods
watch: {
gid () {
cached.files = []
}
},
src/renderer/utils/task.js
Outdated
| @@ -16,7 +16,9 @@ export const initTaskForm = state => { | |||
| engineMaxConnectionPerServer, | |||
| maxConnectionPerServer, | |||
| newTaskShowDownloading, | |||
| split | |||
| split, | |||
| followTorrent, | |||
There was a problem hiding this comment.
Please sort the keys alphabetically
src/renderer/utils/task.js
Outdated
| @@ -32,6 +34,8 @@ export const initTaskForm = state => { | |||
| torrent: '', | |||
| uris: addTaskUrl, | |||
| userAgent: '', | |||
| notFollowMetalink: followMetalink, | |||
There was a problem hiding this comment.
Please sort the keys alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tasks list in task detail has wrong items when user switch between different task. I remove old items which shouldn't appear in new list.
Add a switch for auto download magnet link and torrent. Users can choose whether to automatically start downloading all the files in the torrent or whether to download only the torrent file itself.
Related Issues
Fixes #971
Close #934
Close #440
Checklist: