Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transfer speed setting #292

Merged
merged 1 commit into from
May 27, 2019
Merged

Conversation

jjandxa
Copy link
Contributor

@jjandxa jjandxa commented May 26, 2019

Description

This PR is going to add an transfer setting to the basic preference. The feature request issue is here and trello task is here.

Screenshots

image

Copy link
Owner

@agalwood agalwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete the build folder?

BIN -29.4 KB build/256x256.png
BIN -33.4 KB build/background.tiff
BIN -1000 KB build/icon.icns
BIN -75.1 KB build/icon.ico
BIN -838 KB build/torrent.icns
BIN -59.1 KB build/torrent.ico

@jjandxa
Copy link
Contributor Author

jjandxa commented May 26, 2019

sorry, this is miss operation. will going to do recommit.

Copy link
Owner

@agalwood agalwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the problem and then push the code.

src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
src/renderer/components/Preference/Basic.vue Outdated Show resolved Hide resolved
@jjandxa jjandxa force-pushed the master branch 4 times, most recently from f65b5c7 to 9b45e30 Compare May 26, 2019 13:51
Copy link
Owner

@agalwood agalwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to optimize the naming of variables and class names.

src/renderer/components/Theme/Default.scss Outdated Show resolved Hide resolved
@agalwood agalwood merged commit bc14e5b into agalwood:master May 27, 2019
@lock
Copy link

lock bot commented Jun 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants