AG-12515 Add text and callout e2e tests #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96c5a13
to
5edbd4d
Compare
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10302015830 |
|
Linux snapshots look as expected |
alantreadway
reviewed
Aug 8, 2024
|
|
||
| test.describe('toolbar', () => { | ||
| setupIntrinsicAssertions(); | ||
|
|
||
| const testUrls = toExamplePageUrls('financial-charts', 'financial-charts-showcase'); | ||
| const { url } = toExamplePageUrl('financial-charts-test', 'e2e-toolbar', 'reactFunctionalTs'); |
There was a problem hiding this comment.
Nit: Could we use vanilla JS examples, I think this will scale better as there is less to load (no system JS involved)?
There was a problem hiding this comment.
Is the position of the floating toolbar here correct?
There was a problem hiding this comment.
My eyes failed me, appears to be a bug. Fixed.
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10317192398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-12515
Text and callout tests both cover creating, text also covers editing and changing font size, while callout covers changing colour.
Also simplifies the zoom and line annotation tests to use specific examples for each with simplified charts.