No longer bubble 'error' events from a-asset-items as these interfere with Karma #5548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I noticed that not all unit tests are being executed. Turns out that emitting
error
events causes Karma to stop executing further tests. Interestingly enough this does not seem to be tied to theerror
event handler in__init.test.js
. This PR ensure that theerror
event emitted by<a-asset-item>
doesn't bubble, effectively resolving the issue.Ideally we should avoid using the
error
event name, but I figured that is a bigger breaking change than changing it to not bubble.Before: ✔ 1771 tests completed / ℹ 12 tests skipped
After: ✔ 2475 tests completed / ℹ 16 tests skipped
Note: Above results are obtained by running
npm run test
, which counts test double between FF and ChromeChanges proposed:
error
events from a-asset-items