tickets may not be returned to the pool and isTimeout race condition #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I check the reason why travis failed. It's the same issue as #59. Except for 1.6.0, other versions run just fine. |
|
I found that a potential race condition could happen when the task goroutine passed My solution is to use a local |
|
thanks very much for this fix! |
vermapratyush
added a commit
to myteksi/hystrix-go
that referenced
this pull request
Sep 29, 2017
Adds a buffer on requests before throwing ErrMaxConcurrency. The Timeout is still adhered to, timer starts when the request is submitted to hystrix-go, not when execution starts. This basically implements MaxQueueSize as present in the Netflix's Hystrix The default value of MaxQueueSize is 50 (5 * DefaultMaxConcurrency), although can be overridden when initialising circuit. In addition to the request buffer, the PR includes a different way to solving for afex#67 . It uses channels instead of sync.Once as it makes the Go() function simpler. Also some go-lint fixes. We have been running this in production at GrabTaxi for a while, and there seems to be no side effects. > This also includes a rebase on afex/hystrix-go
vermapratyush
added a commit
to myteksi/hystrix-go
that referenced
this pull request
Sep 30, 2017
Adds a buffer on requests before throwing ErrMaxConcurrency. The Timeout is still adhered to, timer starts when the request is submitted to hystrix-go, not when execution starts. This basically implements MaxQueueSize as present in the Netflix's Hystrix The default value of MaxQueueSize is 50 (5 * DefaultMaxConcurrency), although can be overridden when initialising circuit. In addition to the request buffer, the PR includes a different way to solving for afex#67 . It uses channels instead of sync.Once as it makes the Go() function simpler. Also some go-lint fixes. We have been running this in production at GrabTaxi for a while, and there seems to be no side effects. > This also includes a rebase on afex/hystrix-go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go(), the original logic is one task goroutine acquires a ticket and then another timer goroutine returns it. Albeit it's unlikely, there's a chance that a ticket may never be returned when timer tries to return a ticket before task acquires one.