Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloseNotifier already deprecated use Request.Context instead #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpxxn
Copy link

@lpxxn lpxxn commented Jun 13, 2019

No description provided.

@PriteshJain
Copy link

@afex could you please merge this PR.
This small change will allow us to use latest go version with you lib for streaming hystrix events.

Please help us with this.

@PriteshJain
Copy link

https://github.com/grpc/grpc-go/pull/2697/files
Reference PR that grpc-go has merged as CloseNotifier is deprecated and gives panic on latest go versions.

uknth added a commit to unbxd/hystrix-go that referenced this pull request Oct 19, 2019
uknth added a commit to unbxd/hystrix-go that referenced this pull request Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants