Use I18n strings if available #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tries to call `I18n.t!("email_address.#{name}")` at `error_message()`.
This could raise exceptions in two cases:
- `I18n` doesn't exist (because you are not on Rails)
- The key was not found on i18n YAML files for the current locale
Both cases are caught by the rescue clause, which returns a string based on existing `@errors`.
Now it's possible to define translations inside your Rails app in the regular way.
AlexWayfer
reviewed
Aug 10, 2020
There was a problem hiding this comment.
I don't think that we need it.
There is the pretty simple error messages assignment, it's independent of your translation system.
We can bloat this gem with support of I18n, R18n, GetText, something else. And different users use different keys for translations.
And… anyway, rescuing exception is bad approach for your code. It's better to use something like Object.const_defined? and other conditions for other things.
fauno
added a commit
to fauno/email_address
that referenced
this pull request
Feb 23, 2021
Like afair#67 but I18n is used on Rails' side
Merged
afair
pushed a commit
that referenced
this pull request
Jul 1, 2021
Like #67 but I18n is used on Rails' side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to call
I18n.t!("email_address.#{name}")aterror_message().This could raise exceptions in two cases:
I18ndoesn't exist (because you are not on Rails)Both cases are caught by the rescue clause, which returns a string based on existing
@errors.Now it's possible to define translations inside your Rails app in the regular way.