Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ethernet-switching filter type #318

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

ProtonBruno
Copy link
Contributor

Hi team,
This PR is related to issue #56
As discussed porting our Capirca PR here with associated unit tests.
It's basically adding ethernet-switching filter type for Juniper EX platform.
Thx

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8754c32) 91.23% compared to head (070d31f) 91.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         102      102           
  Lines       22578    22591   +13     
  Branches     3385     3385           
=======================================
+ Hits        20598    20611   +13     
  Misses       1284     1284           
  Partials      696      696           
Flag Coverage Δ
tests 91.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aerleon/lib/aclgenerator.py 92.78% <100.00%> (ø)
aerleon/lib/juniper.py 86.87% <100.00%> (ø)
tests/regression/juniper/juniper_test.py 99.78% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ankenyr
Copy link
Collaborator

ankenyr commented Jul 4, 2023

This is looking good but just to ask, do we know if all features for regular filters are supported with ethernet-switching? addresses and ports look to be supported but what about advanced features such as qos, logging, etc?

@ProtonBruno
Copy link
Contributor Author

Most features are supported but indeed there are some hardware limitations.
It's also the case for QFX filters: we had to remove logging or even filters in some scenario.
We can extend the unit tests to have more coverage and identify the gaps if you want to?

@ankenyr ankenyr merged commit e428edb into aerleon:main Jul 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants