Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark entrypoint and noxfile target #31

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Add benchmark entrypoint and noxfile target #31

merged 2 commits into from
Oct 6, 2022

Conversation

jtwb
Copy link
Member

@jtwb jtwb commented Oct 4, 2022

This adds a benchmark suite based on the samples demo using pyperf. It will write files to the ./benchmark_result directory (gitignored) and you can use pyperf to compare results between multiple runs.

At the moment the complete benchmark runs very slowly (hours). You can run the benchmark against a subset of the sample files by naming which ones to include on the command line, which is much faster as only a couple of the sample files are slow.

In the future I would like to have open PRs run benchmarks in CI and have CI automation add a comment to the PR if performance is significantly degraded by the PR.

@jtwb jtwb requested a review from ankenyr October 4, 2022 17:36
@jtwb jtwb merged commit 98d8760 into main Oct 6, 2022
@jtwb jtwb deleted the benchmark branch October 6, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants