Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old style build tags were not working as intended due misplaced spaces.
// +build amd64, !gccgo, !appengine
In the above old style
+build
line, which is now replaced with//go:build
lines that use a standard boolean syntax, the spaces mean OR, while commas mean AND.When
go fmt
is run on the source with Go 1.17 or 1.18, it translates the above line into the following:So this build line was not considering either the
amd64
orgccgo
tags, just the!appengine
.The intended build tags for siphash_amd64.go seem to be the following:
The tags for siphash_ref.go are still the following:
This resolves a build error with multiple definitions of
core
whengccgo
is set.This also makes
github.com/aead/siphash
into a Go module.