Solved bug?

adolfomunoz · May 10, 2024 · fc9e1cd · fc9e1cd
1 parent 80c9b62
commit fc9e1cd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/control-variates/region-sampling.h b/src/control-variates/region-sampling.h
@@ -33,7 +33,8 @@ class region_sampling_importance {
  }
  auto pos = reg->sample_subrange(sample,range,norm);
  Float den = reg->pdf_subrange(pos,range,norm);
- return std::tuple<std::array<Float,DIM>,Float>(pos,(den<1.e-10)?Float(0):range.volume()/den);
+ if (den<1.e-10) den = 1.0;
+ return std::tuple<std::array<Float,DIM>,Float>(pos,range.volume()/den);
  } 
 };
 

diff --git a/src/newton-cotes/region.h b/src/newton-cotes/region.h
@@ -267,7 +267,7 @@ class Region {
  const std::array<Float,DIMSUB>& b,const Norm& norm = Norm()) const {
  static_assert(DIM>=DIMSUB,"Cannot calculate the subrange pdf for that many dimensions, as the region has less dimensions");
  Float den = this->pdf_integral_subrange(a,b,norm);
- if (den < 1.e-10) den=1;
+ if (den<1.e-10) den=1;
  return Range(a,b).volume()*norm(this->approximation_at(pos))/den;
  }