Seems to be working reasonably OK.

adolfomunoz · May 7, 2024 · f6a8e7a · f6a8e7a
1 parent 579560d
commit f6a8e7a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/control-variates/region-sampling.h b/src/control-variates/region-sampling.h
@@ -32,7 +32,7 @@ class region_sampling_importance {
  sample[i] = dis(rng);
  }
  auto pos = reg->sample_subrange(sample,range,norm);
- return std::tuple<std::array<Float,DIM>,Float>(pos,1.0/reg->pdf_subrange(pos,range,norm));
+ return std::tuple<std::array<Float,DIM>,Float>(pos,range.volume()/reg->pdf_subrange(pos,range,norm));
  } 
 };
 

diff --git a/src/newton-cotes/rules.h b/src/newton-cotes/rules.h
@@ -213,9 +213,9 @@ struct Simpson {
  if ((r>=t0) && (r<=t1)) return r; 
  } 
  //Uniform sampling if not found a solution before
- std::cout<<"Warning, no solutions for range "<<t0<<" - "<<t1;
- for (Float r : res) std::cout<<" "<<r;
- std::cout<<std::endl; 
+ //std::cout<<"Warning, no solutions for range "<<t0<<" - "<<t1;
+ //for (Float r : res) std::cout<<" "<<r;
+ //std::cout<<std::endl; 
  return s*(t1-t0) + t0;
  }