WIP: kustomize: adding CRDs support #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danmx <[email protected]>
kzadorozhny
reviewed
Feb 16, 2021
| @@ -89,6 +89,7 @@ When you run `bazel run ///helloworld:mynamespace.apply`, it applies this file i | |||
| | ***name_prefix*** | `None` | Adds prefix to the names of all resources defined in manifests. | |||
| | ***name_suffix*** | `None` | Adds suffix to the names of all resources defined in manifests. | |||
| | ***patches*** | `None` | A list of patch files to overlay the base manifests. See [Base Manifests and Overlays](#base-manifests-and-overlays). | |||
| | ***crds*** | `None` | A list of custom resource definitions (CRDs) files. The presence of this field is to allow kustomize be aware of CRDs and apply proper transformation for any objects in those types. | |||
There was a problem hiding this comment.
Please link https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/crds/ page in the parameter description.
|
@danmx Thanks for the contribution! Please add a test for this new functionality in |
danmx
changed the title
|
it seems in the end it doesn't work the way I was initially thinking. I'll have to work a little bit more on it. |
|
recommended way is to use configs: kubernetes-sigs/kustomize#480 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: danmx [email protected]
Description
Support Kustomize's CRDs configuration.
Related Issue
Motivation and Context
How Has This Been Tested?
Tested in a private repository.
Types of changes
Checklist: