-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC Auth Provider #59
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
const { ipcRenderer } = require('electron') | ||
|
||
window.startOIDCServer = function() { | ||
ipcRenderer.send("start-oidc", "start"); | ||
} | ||
|
||
window.stopOIDCServer = function() { | ||
ipcRenderer.send("stop-oidc", "stop"); | ||
} | ||
|
||
window.openOIDCURL = function(url) { | ||
ipcRenderer.send("open-oidc-url", url); | ||
} | ||
|
||
|
||
window.onOIDCAuthData = function(callback) { | ||
authData = callback | ||
} | ||
|
||
window.onOIDCAuthError = function(callback) { | ||
authError = callback | ||
} | ||
|
||
window.onOIDCAuthStartError = function(callback) { | ||
authStartError = callback | ||
} | ||
|
||
window.onOIDCAuthStartSuccess = function(callback) { | ||
authStartSuccess = callback | ||
} | ||
|
||
ipcRenderer.on('oidc-auth-data', (event, arg) => { | ||
if (authData) authData(arg); | ||
}); | ||
|
||
ipcRenderer.on('oidc-auth-error', (event, arg) => { | ||
if (authError) authError(arg); | ||
}); | ||
|
||
ipcRenderer.on('oidc-auth-start-error', (event, arg) => { | ||
if (authStartError) authStartError(arg); | ||
}); | ||
|
||
ipcRenderer.on('oidc-auth-start-success', (event, arg) => { | ||
if (authStartSuccess) authStartSuccess(arg); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the server port should be configurable in case it could collide with something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR; Cryptr has been written with the YAGNI principle in mind.
This is unfortunately a complex problem. If the server:port combination used by Cryptr is not also in the approved callback URLs list configured in the OIDC provider, the OIDC provider will cancel the login attempt and produce an error.
By default, Vault CLI uses
http:https://127.0.0.1:8250
as its callback URL, and as such, this URL has the highest likelihood of already being in the OIDC provider's allowlist. For this reason this server:port combination is hardcoded here. Should sufficient need arise for customizing this port, a request can be evaluated.To avoid port conflicts, Cryptr listens on 127.0.0.1:8250 for as short a time as possible. Error handling and retries have been added to ensure Cryptr owns (and is the sole listener on) the port before allowing the OIDC auth flow to proceed. A quick search indicates that few other pieces of software specifically claim this port, so the likelihood of always-on software claiming this port is extremely low.