Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
First proposal on how to add the Vault Enterprise Namespace feature to Cryptr. This should in the long run fix #51 and currently has the maturity of a PoC.
Types of changes
What types of changes does your code introduce to Cryptr?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
I'm pretty inexperienced with Electron and NodeJS development and therefore only trying to get things started towards the implementation of Vault Namespaces in Cryptr. This PR should serve as a PoC to show the level of work required to introduce the support for the Namespace feature in Cryptr.
On remark regarding several package and dependency upgrades this PR includes: I was not able to get Cryptr up and running via
npm dev run
with the current masterpackage.json
and the older Electron version used. I tried and errored myself trough some of the dependency upgrades until I was able to run Cryptr on my machine from source. I would highly appreciate some guidance on the updates I introduced and if they make sense at all.Currently there are some decisions to be taken for the integration of namespaces:
Looking forward to some feedback on this one.
One can this PR with a current enterprise binary from Vault running in dev mode and a namespaces with appropriate policies created: