Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add Vault Namespaces #57

Closed
wants to merge 3 commits into from
Closed

Conversation

danielhass
Copy link

@danielhass danielhass commented Mar 30, 2021

Proposed changes

First proposal on how to add the Vault Enterprise Namespace feature to Cryptr. This should in the long run fix #51 and currently has the maturity of a PoC.

Types of changes

What types of changes does your code introduce to Cryptr?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added necessary documentation (if appropriate)

Further comments

I'm pretty inexperienced with Electron and NodeJS development and therefore only trying to get things started towards the implementation of Vault Namespaces in Cryptr. This PR should serve as a PoC to show the level of work required to introduce the support for the Namespace feature in Cryptr.

On remark regarding several package and dependency upgrades this PR includes: I was not able to get Cryptr up and running via npm dev run with the current master package.json and the older Electron version used. I tried and errored myself trough some of the dependency upgrades until I was able to run Cryptr on my machine from source. I would highly appreciate some guidance on the updates I introduced and if they make sense at all.

Currently there are some decisions to be taken for the integration of namespaces:

  • Where and how to display the namespaces selector/text field. In the current version I went for something similar as the official Vault UI does:
    image
  • Do we need a display for the currently selected namespace inside Cryptr for better usability?
  • Is there anything I didn't think about?

Looking forward to some feedback on this one.

One can this PR with a current enterprise binary from Vault running in dev mode and a namespaces with appropriate policies created:

$ vault+ent server -dev
$ vault namespace create cryptr-test

@danielhass danielhass marked this pull request as draft March 30, 2021 16:38
@danielhass danielhass marked this pull request as ready for review March 30, 2021 16:38
@jcrowthe
Copy link
Collaborator

jcrowthe commented Apr 1, 2021

Hey @danielhass, thanks for providing this support. I should have time to review this next week. Would you mind signing the CLA so we can use this code?

@danielhass danielhass closed this Apr 2, 2021
@danielhass danielhass reopened this Apr 2, 2021
@danielhass
Copy link
Author

@jcrowthe thanks for taking the time to take a look at this. I just signed the CLA and reopened the PR. Checks are now passed.

@jcrowthe
Copy link
Collaborator

Namespace support has been added with cb6d349 which will be released soon as part of v0.6.0.

@jcrowthe jcrowthe closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Vault namespaces
2 participants