Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Lots of menu-related console spam #1292

Closed
peterflynn opened this issue Jul 22, 2012 · 3 comments
Closed

Lots of menu-related console spam #1292

peterflynn opened this issue Jul 22, 2012 · 3 comments

Comments

@peterflynn
Copy link
Member

  1. Launch Brackets
  2. Open the console

Result:
Several dozen copies of this warning message: "Bad Parameter in _getRelativeMenuItem(): relativeID not specified"

@peterflynn
Copy link
Member Author

This was introduced just recently, in pull #1247. Every single one of the built-in calls to addMenuItem() (to create the default Brackets menu structure) generates one of these warnigns. It looks pretty ugly, so I think we should fix it before Sprint 11 goes out the door if possible.

(It also makes it harder for extension developers to spot when their Menu API calls have done something wrong).

peterflynn added a commit that referenced this issue Jul 22, 2012
- Only warn on missing relativeID if 'position' requires a relativeID
Other minor cleanups:
- Add warning if relativeID is a section marker is but 'position' is not
  section-relative
- Remove unused $sectionItems var
- Add TODO about simpifying part of _getRelativeMenuItem()
joelrbrandt added a commit that referenced this issue Jul 23, 2012
Fix issue #1292 (Lots of menu-related console spam)
@ghost ghost assigned peterflynn Jul 23, 2012
@joelrbrandt
Copy link
Contributor

merged #1294. Reassigning to @peterflynn for closing

@pthiess
Copy link
Contributor

pthiess commented Jul 24, 2012

Reviewed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants