[pull] main from stanfordnlp:main #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used, the raw text will be lined up to find the SpaceAfter. Update the test for this outputter as well It turns out this change actually adds SpaceAfter=No misc annotations to -outputFormat CONLLU in the pipeline... perhaps we can claim that is an intended improvement
Remove the old javax.servlet jar (4.0.4 apparently has fewer security issues) Update all servlet uses in .xml files to use jakarta 4.0.4. #1269
…from the original tree starting from 1 instead of 0
Another bug: if this is not set, need to return 0 instead of NPE
…y to pass it from Python to Java in the Semgrex interface
…me way they are being labeled in the valueOf test
The node caching in valueOf now needs to be a 2DMap so that index & emptyIndex are both respected Add a test that valueOf is correctly creating the expected graph
… in the ProtobufAnnotationSerializer
…is will be especially useful when passing around dependency graphs with emptyIndex Don't pass around IndexAnnotation if the implicit index is sufficient (save some space... possibly not necessary)
…dencyGraph proto. Will allow for the passing of UD graphs with fake words
Throws a descriptive exception instead of NPE if a token comes back null, as that will eventually crash anyway Will need to incorporate emptyIndex as well in order to pass around graphs with EmptyIndex
…anticGraph with the fake nodes used in UD Switch to ThreeDimensionalMap for the SemanticGraph nodes and a TwoDimensionalMap for the incoming words
…notationSerializer
…ld version still works, in case there are legacy systems out there or old serialized graphs
…protobuf semgrex processing
…splitting a GrammaticRelation in text form to make a new relation. After all, the code that puts it back together will use : as the separator anyway for Unknown
…al features using Ssurgeon. Currently, there is no way to update features without wiping out the entire features map. This could be changed if needed
…e whole feature map Allow EditNode with morpho updates and no other attributes changed
…ring() which outputs in the format expected by the CoNLLU files. The big advantage of doing this is that it makes Semgrex recognize the features in the format of UD files
…its with what is expected in UD datasets
…rs up that compile error
…, add de- as a verb prefix (presumably doesn't break any exceptions), add blog and xfer as other double letter exceptions
…htmost, or rootmost nodes. I'm the guy who tests his code. You must be the other guy. Addresses #1405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )