[pull] main from stanfordnlp:main #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks like it should be a requirement, not a satisfied
…cking changes or just so other people can see the rules
…ant to switch = and ~ in the SemgrexPattern without ruining old patterns. Since the Javadoc (incorrectly) stated that backreferences were not working for =, hopefully no one will have patterns using =, so as long as we still support the naming function, switching won't break anything... Update ProcessSemgrexRequestTest to match the new restriction (it used to allow both named relation and named edge)
…a very minor bug where deleting an entire graph (such as with a Ssurgeon rule that accidentally deleted everything) results in a graph that can't be printed without NPE
…s subsequent uses of = must match the same exact edge, whereas ~ means the relation name must be the same. Hopefully all existing uses are not broken since they case about the relation string but not the match type, and the relation string can still be matched Switch previously existing uses of ~ to use = now (they were all test cases of the named edge capability)
… script even does (cdm had mentioned deleting it)
… main repo - it has been moved to -research
…te the transform method so the gold & guess trees can have the same punctuation treatment
- the plan is to make the AbstractCollinizer use a difference interface
… tree and the gold tree Not used yet, though - the gold tree is ignored for now
…ld tree can be used to determine whether or not to eliminate the words in the guess tree. This will make it so the test & gold trees are the same, hopefully eliminating most or all of the 'Unable to evaluate...' that happens after retagging trees with the POS tagger Also do the ChineseCollinizer and the NegraPennCollinizer. Both are tested using derivatives of the English test (using English trees, but with the tags specific for the other treebank)
…s as the same objects when deserializing a document
…ght be in Set or Map, and changing the relation would change the hash key
Throw UnsupportedOperationException immediately for a type which can't be converted in UnsupportedOperationException when building a CoreLabel from items
…instead of an iterator to find the edges to be deleted (to ensure the iteration doesn't mess up the maps while iterating)
…parately before using the argsbox (otherwise SetRoots won't correctly parse, for example)
…s of some basic setRoots operations
This operation puts the named edge into the SemgrexMatcher after relabeling something. If the edge already exists, a duplicate is not created. Add a test of this operation
… need to turn generic keys which can't be translated into SsurgeonParseException, and will also want to add a position to the AddDep
…t of sentence) and + (end of sentence, also the default). Need to process -word and +word as well. Will also want to update the SemgrexMatcher so that potentially further operations are possible.
…ate the values on a node
…heck for unreadable attributes at the same time as checking for illegal attributes - this will make EditNode also support checking those attributes
…can report the error line no matter where the error occurs (eg, if it bubbles up from someplace that doesn't know about the editline)
…e SemanticGraph. Includes a test of that functionality
…e edges with the proper dependency scheme. Also, use the version of GrammaticalRelation.valueOf which creates an edge if it doesn't currently exist. This will allow for unknown dependency schemes to work for the most part (although perhaps some bug will crop up anyway)
… the morphological features. Adds that as a feature to ssurgeon
… and its attributes. Allows for whitespace in the xml
… out you can already do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )