Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 2.7 / Leia support #113

Merged
merged 9 commits into from
Dec 2, 2023
Merged

Remove python 2.7 / Leia support #113

merged 9 commits into from
Dec 2, 2023

Conversation

peno64
Copy link
Collaborator

@peno64 peno64 commented Dec 2, 2023

No description provided.

@peno64
Copy link
Collaborator Author

peno64 commented Dec 2, 2023

@michaelarnauts

I get these errors on all tests:


Your code has been rated at 9.40/10

make: *** [Makefile:28: check-pylint] Error 28
Error: Process completed with exit code 1.

Any idea why this is because I don't see it.

@michaelarnauts
Copy link
Contributor

Try adding consider-using-f-string to the .pylintrc file

@michaelarnauts
Copy link
Contributor

You can open the details on the tests, pylint is to verify the actual code and code style. Sometimes new rules are added that you can implement or ignore. I would ignore them for now.

There are also tests that run the actual code to make sure it works. Those run when the checks are done.

@peno64 peno64 merged commit 382c90d into add-ons:master Dec 2, 2023
7 checks passed
@peno64
Copy link
Collaborator Author

peno64 commented Dec 5, 2023

@michaelarnauts

I would like to push the changes to the standard kodi repo but I get the following error:

git push origin matrix
remote: Permission to xbmc/repo-scripts.git denied to peno64.
fatal: unable to access 'https://github.com/xbmc/repo-scripts.git/': The requested URL returned error: 403

Do I not have the permissions to do this?
At https://kodi.wiki/view/Submitting_Add-ons I read: "Only PRs from the add-on author or his successor will be accepted. Patches should be submitted upstream to the original author first."
Is this the issue?

@michaelarnauts
Copy link
Contributor

You'll need to push to your own fork, and make a merge request for that. There is a script in my other repos (in the scripts folder. I think it's named deploy.py) that does this.

I think I'll need to comment on the PR to indicate that you are the successor :)

@peno64
Copy link
Collaborator Author

peno64 commented Dec 6, 2023

But if I pull the changes done on https://github.com/add-ons/service.iptv.manager/ back into my branch, how then can I create a PR again to https://github.com/add-ons/service.iptv.manager because there will be no changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants