fix(framework:skip) Enable SuperNode to complete context registration when FAB is not installed
#4049
+34
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panh99
reviewed
Aug 21, 2024
panh99
approved these changes
Aug 21, 2024
SuperNode to complet context registration when FAB is not installedSuperNode to complete context registration when FAB is not installed
danieljanes
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--isolationis set, theSuperNodedoesn't install theFAB. This prevents thecontext(which needs to be passed to the external process that runs theClientApp) from being fully initialized with the content of thepyproject.tomland, optionally, any override to therun-configThis PR enables yet another way to process
<NodeState>.register_context()that's first extracts thepyproject.tomlfrom aFABw/o installing it.