Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.13.3 Does Not Work on Thuderbird v60.0 #524

Closed
KSR-Yasuda opened this issue Sep 26, 2018 · 12 comments
Closed

v2.13.3 Does Not Work on Thuderbird v60.0 #524

KSR-Yasuda opened this issue Sep 26, 2018 · 12 comments

Comments

@KSR-Yasuda
Copy link

The latest update of Markdown Here (to v2.13.3),
it has come not to work on Thunderbird v60.
I wonder they say it supports v60 (#495)...

  • In mail edit window:
    • It does not respond to keyboard shortcut (Ctrl + Shift + M)
    • No Markdown Here button can be added to toolbar (Such button does not exist)
  • In main window:
    • It can open Markdown Here addon setting page

Also, on Thunderbird v52,
Markdown Here looks not working in mail edit window, same as Thunderbird v60.

Re-installed Markdown Here addon and Thunderbird, however, it does not get well.

I'm quite at a loss as it does not work on any ver. of Thunderbird... X'(

Environment

  • Markdown Here 2.13.3
  • Thunderbird 60.0 (32bit)
  • Windows 8.1 Pro (64bit)
@ensleep
Copy link

ensleep commented Sep 26, 2018

Environment
Markdown Here 2.13.3
Thunderbird 60.0 (32bit)
Windows 10 Pro (64bit)

Does not work too!

@pmanu93
Copy link

pmanu93 commented Sep 26, 2018

Same... After the update I'm unable to use the addon

Environment

  • Markdown Here 2.13.3;
  • Thunderbird 60.0b11 (64 bits);
  • Linux Mint 17.3 (64 bits)

@stombi
Copy link

stombi commented Sep 26, 2018

Same issue as original post (also tested with fresh install and new profile)

Environment

  • Markdown Here 2.13.3
  • Thunderbird 60.0 (64 bits)
  • Linux Debian 8.11 (64 bits)

@adam-p
Copy link
Owner

adam-p commented Sep 26, 2018

Things to try:

  1. If you right-click in the message compose box, do you have the MDH context menu item? Does it work?
  2. Open the MDH options and try setting the hotkey to something else. Maybe Ctrl+Shift+M is specifically problematic.

@stombi
Copy link

stombi commented Sep 26, 2018

  • there is no context menu item
  • tried any combination of Alt / Ctrl / Shift / key (with TB restart each time)

it still doesn't work

edit : context menu item and then transform to markdown works with Thunderbird en_US , my Thunderbird is fr_FR I think

@KSR-Yasuda
Copy link
Author

Neither does my environment:

  1. If you right-click in the message compose box, do you have the MDH context menu item? Does it work?

No context menu of MDH exists.

  1. Open the MDH options and try setting the hotkey to something else. Maybe Ctrl+Shift+M is specifically problematic.

Changed, but it does not respond, either.

It looks MDH add-on is completely not working, but MDH add-on option page.

For now, I anyway rolled back to MDH v2.13.2 and Thunderbird v52.9.1...

@littdky
Copy link

littdky commented Sep 29, 2018

Does not work too!

Environment

  • Markdown Here 2.13.3
  • Thunderbird 60.0 (32bit)
  • Windows 10 Pro (64bit)

@adam-p
Copy link
Owner

adam-p commented Sep 29, 2018

@stombi : Thanks for this clue:

edit : context menu item and then transform to markdown works with Thunderbird en_US , my Thunderbird is fr_FR I think

Does everyone else use a non-English Thunderbird UI? I've reproduced the problem when using a different language.

@ensleep
Copy link

ensleep commented Sep 30, 2018

@adam-p very nice .I think it will be upgrade someday ^V^

@adam-p adam-p closed this as completed in 54fb24b Sep 30, 2018
adam-p added a commit that referenced this issue Sep 30, 2018
Fix #524 and #526: Broken in non-English Thunderbird
@adam-p
Copy link
Owner

adam-p commented Sep 30, 2018

Fixed by PR #527, in v2.13.4. Currently in Mozilla review queue (position 18 of 18).

@adam-p
Copy link
Owner

adam-p commented Sep 30, 2018

Mozilla approved the new version just now. You should get the update automatically, or you can down it from here: https://addons.thunderbird.net/en-US/thunderbird/addon/markdown-here-xul/versions/

@KSR-Yasuda
Copy link
Author

Now it goes well with v2.13.4. Thank you!

Does everyone else use a non-English Thunderbird UI?

Yes, mine is non-English, too (Japanese).
So, that was it, huh?

NyanKiyoshi pushed a commit to NyanKiyoshi/markdown-here that referenced this issue Feb 27, 2020
A string added in the Firefox 60 fix wasn't copied to the non-English `messages.json` files, which meant that it wasn't in the non-English `strings.properties` and `string.dtd` files. This caused Thunderbird to not load the overlay in Thunderbird, which prevented it from being present in the message window.

To help mitigate this in the future, to some degree, the `i18n.js` script makes sure that all English strings are present in the other languages when creating the the .properties and .dtd files. But I still have to remember to run that script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants