Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Here Upgrade Notification every time I open Chrome #109

Closed
jhwarehouse opened this issue Oct 8, 2013 · 14 comments
Closed

Markdown Here Upgrade Notification every time I open Chrome #109

jhwarehouse opened this issue Oct 8, 2013 · 14 comments
Milestone

Comments

@jhwarehouse
Copy link

Hi Adam,
First I'd like to say I use your extension every day and love it. The most recent update keeps telling me it upgraded every time I close all chrome windows and open a new one. I've tried to click the little "x" to dismiss it and clicked on the message to read the release notes. I'm running Windows 8.1 and Chrome Version 30.0.1599.69 m if that helps.

@adam-p
Copy link
Owner

adam-p commented Oct 8, 2013

Well, that's annoying.

Can you do this for me:

Errors from the content script:

  1. On a tab with the upgrade notification showing, open the Developer Tools (F12). Switch it to the Console view.
  2. Dismiss the notification (with X). Do you see any output in the Console?

Errors from the background script:

  1. Open the background script console (see the animated gif below).
  2. Do you see any errors?
  3. Run the commands shown in the animated gif. The previous Chrome version was 2.8.1 and the current is 2.9.0. What do you see?

options-version

Edit: Changed screen animation to use OptionsStore rather than chrome.storage.sync directly. It's more correct that way (the version is supposed to be a JSON string, not a bare string). It was working fine, but this is better.

@jhwarehouse
Copy link
Author

Hi Adam,

Wow, thanks for such a quick reply. I followed all of your steps and
didn't see any error's in the content of background script. However,
running the commands from the gif seems to have corrected the issue. The
output is below. Thanks a bunch.

[image: Inline image 1]

On Tue, Oct 8, 2013 at 10:15 AM, Adam Pritchard [email protected]:

Well, that's annoying.

Can you do this for me:

Errors from the content script:

  1. On a tab with the upgrade notification showing, open the Developer
    Tools (F12). Switch it to the Console view.
  2. Dismiss the notification (with X). Do you see any output in the
    Console?

Errors from the background script:

  1. Open the background script console (see the animated gif below).
  2. Do you see any errors?
  3. Run the commands shown in the animated gif. The previous Chrome version
    was 2.8.1 and the current is 2.9.0. What do you see?

[image: options-version]https://f.cloud.github.com/assets/425687/1290963/962e96fa-303a-11e3-8597-648f70a77dd2.gif


Reply to this email directly or view it on GitHubhttps://github.com//issues/109#issuecomment-25909344
.

@Xarkam
Copy link

Xarkam commented Oct 8, 2013

Hello,

chrome.storage.sync.get(function(prefs) {console.log(prefs['last-version'])})

the result of command is 2.8.1

In extensions, chrome show 2.9.0

Edit

I remove the old folder 2.8.1_1 in chrome extensions folder and it's same.

@adam-p
Copy link
Owner

adam-p commented Oct 8, 2013

@Xarkam: Do you have any errors/exceptions in the background script console?

@adam-p
Copy link
Owner

adam-p commented Oct 8, 2013

If anyone else has this problem, please chime in. That way we can determine if it's isolated to a few users of if everyone is experiencing it.

@jhwarehouse, @Xarkam: Did you try closing and re-opening the browser to fix the problem?

@AviDuda
Copy link

AviDuda commented Oct 8, 2013

Same problem. last-version was set to 2.8.1 (and the Extensions tab is showing 2.9.0), setting last-version to 2.9.0 fixes the issue.

@Xarkam
Copy link

Xarkam commented Oct 9, 2013

@adam-p yes I closed the browser several times.

@TomasDuda howto change the last-version ?

@AviDuda
Copy link

AviDuda commented Oct 9, 2013

@Xarkam Open the extension console as it's in @adam-p's GIF and run this command: chrome.storage.sync.set({'last-version': '2.9.0'})

adam-p added a commit that referenced this issue Oct 9, 2013
…first-run options page, and those actions only occur when it completes. Hopefully this helps with #109.
@adam-p
Copy link
Owner

adam-p commented Oct 9, 2013

I made a change that hopefully will help with this: bf02e0c

I'm still not sure if this just happened for some people with options storage problems, or for everyone. Since 10,000 people aren't chiming in, I guess probably not for everyone?

@jhwarehouse @Xarkam @TomasDuda : Can you try one more thing for me? Unlike most releases, I left the self-test code in for Chrome this time. Can you run it? I created another animated GIF instruction thing. Let me know if you see any errors or red Xs or whatever.

options-test

@jhwarehouse
Copy link
Author

HI Adam,

I ran the self test as you mentioned and it resulted in "passes: 86
failures: 0 duration 1.13s" and everything is green checks so it looks like
it all passed to me. I included screenshots of the test results for you if
that helps. I also didn't have the popup today telling me it had been
updated but that may not be a surprise since it doesn't look like the
version changed. I tried one more thing for you and manually set the
last-version back to 2.8.1 and restarted chrome. The issue still happens
for me where even after I dismissed the update notification the
last-version didn't update and the pop-up kept happening. I once again set
it back to 2.9.0 and all is well again. I know how difficult it can be to
troubleshoot issues that you can't replicate yourself so let me know if
there is anything else I can do to assist.

Thanks,
Chris

[image: Inline image 1]
[image: Inline image 2]
[image: Inline image 3]
On Wed, Oct 9, 2013 at 7:29 AM, Adam Pritchard [email protected]:

I made a change that hopefully will help with this: bf02e0chttps://github.com/adam-p/markdown-here/commit/bf02e0c

I'm still not sure if this just happened for some people with options
storage problems, or for everyone. Since 10,000 people aren't chiming in, I
guess probably not for everyone?

@jhwarehouse https://github.com/jhwarehouse @Xarkamhttps://github.com/Xarkam
@TomasDuda https://github.com/TomasDuda : Can you try one more thing
for me? Unlike most releases, I left the self-test code in for Chrome this
time. Can you run it? I created another animated GIF instruction thing. Let
me know if you see any errors or red Xs or whatever.

[image: options-test]https://f.cloud.github.com/assets/425687/1298129/2a5f31cc-30ef-11e3-8b5a-acd1650bd50f.gif


Reply to this email directly or view it on GitHubhttps://github.com//issues/109#issuecomment-25975487
.

@Xarkam
Copy link

Xarkam commented Oct 9, 2013

All pass is green in setting version to 2.8.1 and 2.9.0

@emilsoman
Copy link

I had the same problem. Set the version to 2.9.0 . Not getting the error till now.

@adam-p
Copy link
Owner

adam-p commented Oct 11, 2013

I'll be releasing a hopefully/maybe fix for this today, so I'm closing it. Please reopen if it happens again.

@adam-p adam-p closed this as completed Oct 11, 2013
@jhwarehouse
Copy link
Author

Hi again Adam,
I'm sorry to be the bearer of bad news but it's still happening for me with 2.9.1. I manually set the last-version to 2.9.1 and of course the issue went away again. Here's a screenshot that shows it was still showing 2.9.0 until I manually set it. I've also included a screenshot of the other extensions I have installed in case it's some kind of conflict. Let me know if you need anything else or have something you want me to try out for you.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants