Add configurable I2C addresses #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Apr 5, 2021
ladyada
requested changes
Apr 5, 2021
Formatting improvements
Formatting again.
ladyada
approved these changes
Apr 5, 2021
|
thanx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the class to work on other addresses configured with the SA0/1 pins on the FXOS8700. It still defaults to the current address as configured by Adafruit's 9-axis board, and was implemented such that any code currently working with this class will still function as-is.
This configuration option on other Sensor libraries is implemented as part of the
begin()method. However, implementing it here would have possible breaking-change possibilities given there's already a configuration option in this method. I am open to thoughts on placing it here to be more standardized.I have tested with the Freescale Freedom board with these devices on it with a Grand Central M4, because those are the boards I have, but the logical structure is all still the same so shouldn't impact the operation previously.