Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: applying patch at the right time #3246

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

asalzburger
Copy link
Contributor

The change to the ActsExternSources made the geomodel patch been looked at in the wrong CURRENT_SOURCE_DIR (i.e. the cmake/*), hence it could not been applied.

@asalzburger asalzburger added this to the next milestone Jun 4, 2024
@asalzburger asalzburger requested a review from fredevb June 4, 2024 14:53
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.65%. Comparing base (5885ee8) to head (fa4a70a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3246   +/-   ##
=======================================
  Coverage   47.65%   47.65%           
=======================================
  Files         507      507           
  Lines       29205    29205           
  Branches    14010    14010           
=======================================
  Hits        13917    13917           
  Misses       5264     5264           
  Partials    10024    10024           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger
Copy link
Member

paulgessinger commented Jun 5, 2024

I just added @fredevb to the reviewer team. I think you'll need to accept the invite before policybot will accept your review.

Never mind, looks good now.

@kodiakhq kodiakhq bot merged commit 80a03ea into acts-project:main Jun 5, 2024
51 checks passed
@github-actions github-actions bot removed the automerge label Jun 5, 2024
@andiwand andiwand modified the milestones: next, v35.2.0 Jun 16, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
The change to the `ActsExternSources`  made the geomodel patch been looked at in the wrong `CURRENT_SOURCE_DIR` (i.e. the `cmake/*`), hence it could not been applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants