Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Tweak AMVF config tracksMaxSignificance with time in Examples #2986

Closed
wants to merge 2 commits into from
Closed

fix: Tweak AMVF config tracksMaxSignificance with time in Examples #2986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f47ee
remove increase of tracksMaxSignificance
andiwand Feb 23, 2024
d9f973c
explicit value
andiwand Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Examples/Algorithms/Vertexing/src/AdaptiveMultiVertexFinderAlgorithm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,8 @@ auto ActsExamples::AdaptiveMultiVertexFinderAlgorithm::makeVertexFinder() const
finderConfig.tracksMaxZinterval = 1. * Acts::UnitConstants::mm;
finderConfig.maxIterations = 200;
finderConfig.useTime = m_cfg.useTime;
finderConfig.tracksMaxSignificance = 5;
if (m_cfg.useTime) {
// When using time, we have an extra contribution to the chi2 by the time
// coordinate. We thus need to increase tracksMaxSignificance (i.e., the
// maximum chi2 that a track can have to be associated with a vertex).
finderConfig.tracksMaxSignificance = 7.5;
// Check if vertices are merged in space and time
// TODO rename do3dSplitting -> doFullSplitting
finderConfig.do3dSplitting = true;
Expand Down
Loading