fix: Tweak AMVF config with time in Examples

[andiwand]

I observed higher vertex efficiency with time setting maxMergeVertexSignificance to default. tracksMaxSignificance and doFullSplitting were also reset in order to use the same config with and without time.

[andiwand]

Let's see what the physmon performance says

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.84%. Comparing base (3a4c1d4) to head (1c508ec).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2985   +/-   ##
=======================================
  Coverage   48.84%   48.84%           
=======================================
  Files         492      492           
  Lines       28861    28861           
  Branches    13685    13685           
=======================================
  Hits        14096    14096           
  Misses       4955     4955           
  Partials     9810     9810           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 1c508ec

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[paulgessinger]

Physmon seems compatible with efficiency increase.

[andiwand]

After discussion with @pbutti we agreed on splitting the change to see what option drives what performance.

One problem with our current monitoring is that we do not know if the additional vertices are duplicates or fakes. We will have to dig a bit deeper to check that.

[felix-russo]

lgtm

For lower pile up (i.e., mu=50 like in our physmon), I used to see a better performance when this line was there

For higher pile-up (i.e., mu = 200 like in the setup for the paper) the performance was better without it

If now the performance is better for low pile-ups as well, we should definitely remove it

If we encounter bad performance in a new setup, I would always consider tweaking this parameter too see what happens. Adding a python binding might be good in the future.

Invalidated by push of fc12aff

[andiwand]

physmon looks good now

[acts-project-service]

✅ Athena integration test results [dac4a44]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco