Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix TruthVertexFinder for not reconstructed particles #2979

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 21, 2024

This fixes an overlook in #2937. Non reconstructed particles result in an exception which is fixed here

@andiwand andiwand added this to the next milestone Feb 21, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Feb 21, 2024
@andiwand andiwand changed the title fix: Fix TruthVertexFinder fix: Fix TruthVertexFinder for not reconstructed tracks Feb 21, 2024
@andiwand andiwand changed the title fix: Fix TruthVertexFinder for not reconstructed tracks fix: Fix TruthVertexFinder for not reconstructed particles Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.73%. Comparing base (032dd9a) to head (8dfd5cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2979   +/-   ##
=======================================
  Coverage   48.73%   48.73%           
=======================================
  Files         493      493           
  Lines       28943    28943           
  Branches    13776    13776           
=======================================
  Hits        14106    14106           
  Misses       4924     4924           
  Partials     9913     9913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand marked this pull request as ready for review February 26, 2024 12:12
@kodiakhq kodiakhq bot merged commit e06342c into acts-project:main Feb 26, 2024
54 checks passed
@andiwand andiwand deleted the fix-truthvtxfinder branch February 26, 2024 15:59
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…oject#2979)

This fixes an overlook in acts-project#2937. Non reconstructed particles result in an exception which is fixed here
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…oject#2979)

This fixes an overlook in acts-project#2937. Non reconstructed particles result in an exception which is fixed here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants