Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Robust perigee propagation in HelicalTrackLinearizer #2930

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 5, 2024

This fixes another case where the overstepping tolerance bites us from behind. Perigee surfaces are prone to the issue of bad path length estimation so we need a special treatment.

discovered in #2917

@andiwand andiwand added this to the next milestone Feb 5, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Vertexing labels Feb 5, 2024
@paulgessinger
Copy link
Member

Can we synchronize this with my vertexing changes? I'm changing how the linearizer calls into the propagation.

@andiwand
Copy link
Contributor Author

andiwand commented Feb 5, 2024

Can we synchronize this with my vertexing changes? I'm changing how the linearizer calls into the propagation.

Sure this is not in a rush. I fear that this is conflicting with your changes and I am not sure how to best resolve that yet

@andiwand andiwand changed the title fix: Robust perigee propagation in HelicalTrackLinearlizer fix: Robust perigee propagation in HelicalTrackLinearizer Feb 6, 2024
@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Feb 13, 2024
@andiwand
Copy link
Contributor Author

blocked by vertexing refactor atm

@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label Mar 1, 2024
@github-actions github-actions bot removed the Vertexing label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 48.86%. Comparing base (afebfab) to head (9e0964b).

Files Patch % Lines
Core/include/Acts/Propagator/Propagator.ipp 0.00% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2930      +/-   ##
==========================================
+ Coverage   48.68%   48.86%   +0.18%     
==========================================
  Files         493      493              
  Lines       29052    29058       +6     
  Branches    13850    13798      -52     
==========================================
+ Hits        14143    14200      +57     
+ Misses       4965     4962       -3     
+ Partials     9944     9896      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Mar 8, 2024
@andiwand
Copy link
Contributor Author

andiwand commented Mar 8, 2024

@paulgessinger I fear something broke in the physmon monitoring https://github.com/acts-project/acts/actions/runs/8204327988 failed but is flagged as green

@paulgessinger
Copy link
Member

@andiwand i think the job that should update the content just didn't run (yet?)

@kodiakhq kodiakhq bot merged commit 4d56bab into acts-project:main Mar 8, 2024
56 checks passed
@github-actions github-actions bot removed the automerge label Mar 8, 2024
@andiwand andiwand deleted the heltrklin-robust-perigee-propagation branch March 8, 2024 17:34
dimitra97 pushed a commit to dimitra97/acts that referenced this pull request Mar 19, 2024
…ject#2930)

This fixes another case where the overstepping tolerance bites us from behind. Perigee surfaces are prone to the issue of bad path length estimation so we need a special treatment.

discovered in acts-project#2917
@paulgessinger paulgessinger modified the milestones: next, v33.1.0 Mar 26, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…ject#2930)

This fixes another case where the overstepping tolerance bites us from behind. Perigee surfaces are prone to the issue of bad path length estimation so we need a special treatment.

discovered in acts-project#2917
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…ject#2930)

This fixes another case where the overstepping tolerance bites us from behind. Perigee surfaces are prone to the issue of bad path length estimation so we need a special treatment.

discovered in acts-project#2917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants