Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Test KF direct navigation #2922

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 1, 2024

Since this broke lately without noticing in ACTS but later on in ATHENA we would like to add this to the Python level tests

@andiwand andiwand added this to the next milestone Feb 1, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d043298) 48.84% compared to head (39975d3) 48.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2922   +/-   ##
=======================================
  Coverage   48.84%   48.84%           
=======================================
  Files         495      495           
  Lines       28909    28909           
  Branches    13732    13732           
=======================================
  Hits        14122    14122           
  Misses       4890     4890           
  Partials     9897     9897           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand
Copy link
Contributor Author

andiwand commented Feb 1, 2024

looks like this is not producing any errors @paulgessinger

I guess we have to inspect the track summary to check if there are entries?

@paulgessinger
Copy link
Member

Could add a check to the end of the job asserting we have track parameters attached from the track

@andiwand
Copy link
Contributor Author

andiwand commented Feb 1, 2024

@paulgessinger I fear my setup is not reproducing the bug

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's good to have this monitored.

@andiwand andiwand added the 🚧 WIP Work-in-progress label Feb 5, 2024
@andiwand andiwand added automerge and removed 🚧 WIP Work-in-progress labels Feb 14, 2024
@kodiakhq kodiakhq bot merged commit 55d49ec into acts-project:main Feb 14, 2024
54 checks passed
@andiwand andiwand deleted the test-kf-direct-navigation branch February 14, 2024 20:52
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
Since this broke lately without noticing in ACTS but later on in ATHENA we would like to add this to the Python level tests
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Since this broke lately without noticing in ACTS but later on in ATHENA we would like to add this to the Python level tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants