Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Python dump_args_calls crash #2920

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

timadye
Copy link
Contributor

@timadye timadye commented Jan 31, 2024

  • Fix crash when acts.examples.dump_args_calls() is enabled before creating an acts.examples.Sequencer()
  • More comprehensive argument printout

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c32e1b) 48.94% compared to head (c4801a7) 48.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2920   +/-   ##
=======================================
  Coverage   48.94%   48.94%           
=======================================
  Files         496      496           
  Lines       28913    28913           
  Branches    13710    13710           
=======================================
  Hits        14151    14151           
  Misses       4878     4878           
  Partials     9884     9884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJPfleger AJPfleger added this to the next milestone Feb 1, 2024
@kodiakhq kodiakhq bot merged commit a76b24c into acts-project:main Feb 1, 2024
52 checks passed
@github-actions github-actions bot removed the automerge label Feb 1, 2024
@paulgessinger paulgessinger modified the milestones: next, v32.1.0 Feb 2, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
* Fix crash when `acts.examples.dump_args_calls()` is enabled before creating an `acts.examples.Sequencer()`
* More comprehensive argument printout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants