feat: Add TryAllOverstepNavigator
#2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
📊: Physics performance monitoring for 0c93c4bphysmon summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2850 +/- ##
==========================================
+ Coverage 47.43% 47.46% +0.02%
==========================================
Files 510 510
Lines 30053 30198 +145
Branches 14564 14639 +75
==========================================
+ Hits 14257 14332 +75
- Misses 5323 5335 +12
- Partials 10473 10531 +58 ☔ View full report in Codecov by Sentry. |
andiwand
changed the title
TryAllOverstepNavigator
andiwand
force-pushed
the
try-all-overstep-navigator
branch
from
5a2ab0a
to
eb74c80
Compare
andiwand
added
🛑 blocked
andiwand
force-pushed
the
try-all-overstep-navigator
branch
from
99b02e3
to
87ea1bc
Compare
andiwand
force-pushed
the
try-all-overstep-navigator
branch
from
87ea1bc
to
c96277c
Compare
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jun 14, 2024
This PR adds another "try all" navigator which deliberately oversteps and runs intersections backwards. It can be used as a reference to validate other navigators. The idea of intersecting backwards is to have a better approximation with the helix. Instead of using the tangent we will use a ray that goes through the trajectory twice. depends on - acts-project#2846 - acts-project#2849
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jun 14, 2024
After acts-project#2849 and acts-project#2850 it is time to update the documentation of our navigators. I also included a line about the `DetectorNavigator`. blocked by - acts-project#2850
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
This PR adds another "try all" navigator which deliberately oversteps and runs intersections backwards. It can be used as a reference to validate other navigators. The idea of intersecting backwards is to have a better approximation with the helix. Instead of using the tangent we will use a ray that goes through the trajectory twice. depends on - acts-project#2846 - acts-project#2849
Matthewharri
pushed a commit
to Matthewharri/acts
that referenced
this pull request
Jun 18, 2024
After acts-project#2849 and acts-project#2850 it is time to update the documentation of our navigators. I also included a line about the `DetectorNavigator`. blocked by - acts-project#2850
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
## Issue The test-time for build_debug grew significantly after: - #2849 - #2850 Before: ``` Start 127: Navigator 127/239 Test #127: Navigator ............................ Passed 22.29 sec ``` TryAllNavigator: ``` Start 128: Navigator 128/240 Test #128: Navigator ............................ Passed 1041.82 sec ``` TryAllOverstepNavigator: ``` Start 128: Navigator 128/240 Test #128: Navigator ............................ Passed 3994.42 sec ``` ## Possible Solution This PR reduces the number of tests with the try-all-references from 500 to 10. This results in a test time of around 200 sec. Maybe we should adapt the test in the future to get more tests in a similar time.
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
This PR adds another "try all" navigator which deliberately oversteps and runs intersections backwards. It can be used as a reference to validate other navigators. The idea of intersecting backwards is to have a better approximation with the helix. Instead of using the tangent we will use a ray that goes through the trajectory twice. depends on - acts-project#2846 - acts-project#2849
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
After acts-project#2849 and acts-project#2850 it is time to update the documentation of our navigators. I also included a line about the `DetectorNavigator`. blocked by - acts-project#2850
timadye
pushed a commit
to andiwand/acts
that referenced
this pull request
Jun 27, 2024
) ## Issue The test-time for build_debug grew significantly after: - acts-project#2849 - acts-project#2850 Before: ``` Start 127: Navigator 127/239 Test acts-project#127: Navigator ............................ Passed 22.29 sec ``` TryAllNavigator: ``` Start 128: Navigator 128/240 Test acts-project#128: Navigator ............................ Passed 1041.82 sec ``` TryAllOverstepNavigator: ``` Start 128: Navigator 128/240 Test acts-project#128: Navigator ............................ Passed 3994.42 sec ``` ## Possible Solution This PR reduces the number of tests with the try-all-references from 500 to 10. This results in a test time of around 200 sec. Maybe we should adapt the test in the future to get more tests in a similar time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another "try all" navigator which deliberately oversteps and runs intersections backwards. It can be used as a reference to validate other navigators.
The idea of intersecting backwards is to have a better approximation with the helix. Instead of using the tangent we will use a ray that goes through the trajectory twice.
depends on
TryAllNavigator#2849