Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger level when dd4hep conversion fails is only info #3080

Closed
simonge opened this issue Apr 4, 2024 · 0 comments · Fixed by #3092
Closed

Logger level when dd4hep conversion fails is only info #3080

simonge opened this issue Apr 4, 2024 · 0 comments · Fixed by #3092

Comments

@simonge
Copy link

simonge commented Apr 4, 2024

Logger level of:
https://github.com/acts-project/acts/blob/main/Plugins/DD4hep/src/ConvertDD4hepDetector.cpp#L532
is currently only info, this could be upgraded to a warning to better highlight the issue.
@AJPfleger AJPfleger mentioned this issue Apr 9, 2024
Merged
@kodiakhq kodiakhq bot closed this as completed in #3092 Apr 10, 2024
kodiakhq bot pushed a commit that referenced this issue Apr 10, 2024
@AJPfleger
refactor(DD4hep): change logger level for conversion fail (#3092)
5d3461f 
resolves #3080, as discussed on 09.04.2024 in the developers meeting.
Ragansu pushed a commit to Ragansu/acts that referenced this issue Apr 19, 2024
@AJPfleger @Ragansu
refactor(DD4hep): change logger level for conversion fail (acts-proje…
8480380 
…ct#3092)

resolves acts-project#3080, as discussed on 09.04.2024 in the developers meeting.
EleniXoch pushed a commit to EleniXoch/acts that referenced this issue May 6, 2024
@AJPfleger @EleniXoch
refactor(DD4hep): change logger level for conversion fail (acts-proje…
29065c9 
…ct#3092)

resolves acts-project#3080, as discussed on 09.04.2024 in the developers meeting.
asalzburger pushed a commit to asalzburger/acts that referenced this issue May 21, 2024
@AJPfleger @asalzburger
refactor(DD4hep): change logger level for conversion fail (acts-proje…
f55756b 
…ct#3092)

resolves acts-project#3080, as discussed on 09.04.2024 in the developers meeting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(DD4hep): change logger level for conversion fail AJPfleger/acts
1 participant
@simonge