PR feedback. Juse more JS idiomatic code

actions · May 20, 2024 · 7d18e7a · 7d18e7a
1 parent e606940
commit 7d18e7a
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/packages/attest/src/endpoints.ts b/packages/attest/src/endpoints.ts
@@ -42,15 +42,14 @@ export const signingEndpoints = (sigstore?: SigstoreInstance): Endpoints => {
 }
 
 function buildGitHubEndpoints(): Endpoints {
- const serverURL = process.env.GITHUB_SERVER_URL ?? `https://github.com`
- let url = serverURL.replace('https://', '')
+ const serverURL = process.env.GITHUB_SERVER_URL || 'https://github.com'
+ let host = new URL(serverURL).hostname
 
- if (url === 'github.com') {
- url = 'githubapp.com'
+ if (host === 'github.com') {
+ host = 'githubapp.com'
  }
- const endpoints: Endpoints = {
- fulcioURL: `https://fulcio.${url}`,
- tsaServerURL: `https://timestamp.${url}`
+ return {
+ fulcioURL: `https://fulcio.${hostl}`,
+ tsaServerURL: `https://timestamp.${host}`
  }
- return endpoints
 }