Support lts/-n aliases #481

jablko · 2022-05-02T20:01:13Z

Description:
#270 added support for lts/<alias> and lts/* nvm aliases. This adds support for nvm's (and hence .nvmrc/node-version-file's) lts/-n: nvm-sh/nvm#1998 (comment)

Related issue:
#481

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

e-korolevskii · 2022-05-06T09:25:23Z

Hi, @jablko,

You need to manually run build and add the results to the PR.

Cheers.

jablko · 2022-05-06T14:23:10Z

Thank you @e-korolevskii! I've added the build products to the commit.

dmitry-shibanov · 2022-05-10T13:47:50Z

Hello @jablko. Could you please add e2e tests for new syntax ?

jablko · 2022-05-10T14:29:47Z

@dmitry-shibanov Thanks for reviewing! I've now added an e2e test.

jablko · 2022-05-10T19:59:54Z

@dmitry-shibanov I noticed:

The e2e test exposed a mistake I made and have now corrected.
The lts-syntax e2e test was missing a "Verify node and npm" step like the other versions.yml jobs, so I added that too.

jablko · 2022-05-13T23:14:13Z

I've rebased and combined the repetitive LTS tests with it.each(table) --- but I'm happy to leave them unrolled if you prefer?

dmitry-shibanov · 2022-05-30T11:01:02Z

Hello @jablko. Could you please sync with the main branch ?

jablko · 2022-05-30T17:46:07Z

@dmitry-shibanov Yes, I've rebased this.

dmitry-shibanov · 2022-05-30T20:30:28Z

Hello @jablko. I think we should not reverse initial manifest. If we specify check-latest to true the action won't return the latest lts version for lts aliases.

https://github.com/actions/setup-node/runs/6659118565?check_suite_focus=true#step:3:10

The code return the major version that is why when searching for a satisfied version in the reversed array, not the latest version will be taken.

jablko · 2022-05-30T23:44:32Z

Thanks @dmitry-shibanov, you're right, tc.findFromManifest() depends on the manifest's order.

I've added an entry to the unit tests' mock manifest, so one of its major versions has at least two minor versions, which exposes my mistake. Then I removed the .reverse() and confirmed the tests pass again and we get the max satisfying version when check-latest is true.

callree

This PR contains the following updates: Package Change Age Adoption Passing Confidence Type Update @astrojs/partytown (source) 1.0.0 -> 1.0.1 dependencies patch @picocss/pico (source) 1.5.5 -> 1.5.6 dependencies patch @types/node (source) 18.7.23 -> 18.8.3 devDependencies minor actions/checkout v3.0.0 -> v3.1.0 action minor actions/setup-node v3.0.0 -> v3.5.0 action minor actions/stale v6.0.0 -> v6.0.1 action patch astro (source) 1.3.1 -> 1.4.6 dependencies minor astro-netlify-cms 0.2.2 -> 0.2.3 dependencies patch cspell (source) 6.10.1 -> 6.12.0 devDependencies minor eslint (source) 8.24.0 -> 8.25.0 devDependencies minor eslint-plugin-astro (source) 0.19.0 -> 0.20.0 devDependencies minor nick-fields/retry v2.6.0 -> v2.8.1 action minor postcss (source) 8.4.16 -> 8.4.17 devDependencies patch prettier-plugin-astro 0.5.4 -> 0.5.5 devDependencies patch prettier-plugin-prisma 4.2.0 -> 4.4.0 devDependencies minor vite (source) 3.1.4 -> 3.1.6 devDependencies patch Release Notes withastro/astro (@astrojs/partytown) v1.0.1 Compare Source Patch Changes #4989 50a397c4b Thanks @that-joao! - Update @builder.io/partytown dependency picocss/pico v1.5.6 Compare Source Features Adds the ability to compile Pico with a root element other than body (E.g. #__next, #___gatsby, #root), by @ja1den Define your your CSS selector in scss/_variables.scss > $semantic-root-element #224 #13 #222 Fixes aria-invalid for dates input, by @rbf #242 #243 Documentation Improves Customization and Class-less pages #245 Full changelog A huge thank you to all the contributors ❤️ actions/checkout v3.1.0 Compare Source Use @actions/core saveState and getState Add github-server-url input v3.0.2 Compare Source Add input set-safe-directory v3.0.1 Compare Source Fixed an issue where checkout failed to run in container jobs due to the new git setting safe.directory Bumped various npm package versions actions/setup-node v3.5.0 Compare Source In scope of this release we add support for engines.node. The action will be able to grab the version form package.json#engines.node. actions/setup-node#485. Moreover, we added support for Volta Besides, we updated @actions/core to 1.9.1 and @actions/cache to 3.0.4 v3.4.1 Compare Source In scope of this release we fixed bugs related to the pnpm 7.5.1 output issue from pnpm store path actions/setup-node#545. Moreover we fixed the issue with falling on node-version output actions/setup-node#540. v3.4.0 Compare Source In scope of this release we updated actions/cache package as the new version contains fixes for caching error handling. Moreover, we added support for asdf format as Node.js version file actions/setup-node#373. Besides, we introduced new output node-version and added npm-shrinkwrap.json to dependency file patterns: actions/setup-node#439 v3.3.0 Compare Source In scope of this release we added support for lts/-n aliases, improve logic for current, latest and node aliases to handle them from toolcache, update ncc package. Support of lts/-n aliases Related pull request: actions/setup-node#481 Related issue: actions/setup-node#26 steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: lts/-1 - run: npm ci - run: npm test Minor improvements Update zeit/ncc to vercel/ncc: actions/setup-node#476 Get latest version from cache if exists: actions/setup-node#496 v3.2.0 Compare Source In scope of this release we added new aliases to install the latest Node.js version. actions/setup-node#483 steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: current - run: npm ci - run: npm test v3.1.1 Compare Source In scope of this release we updated actions/cache package as the new version contains fixes related to GHES 3.5 (actions/setup-node#460) v3.1.0 Compare Source In scope of this release we added support for caching from GHES 3.5 and fixed download issue for files > 2GB during restore. Besides, we updated actions/cache dependency to 2.0.0 version. actions/stale v6.0.1 Compare Source Update @actions/core to 1.10.0 #839 Full Changelog: actions/[email protected] withastro/astro (astro) v1.4.6 Compare Source Patch Changes #5013 ffbe4e71e Thanks @matthewp! - Fixes getViteConfig from astro/config v1.4.5 Compare Source Patch Changes #4981 1f890b336 Thanks @matthewp! - Ensure dynamic tags have their slot instructions yielded #4886 61d26f335 Thanks @yuhang-dong! - Fix: import.meta.env.BASE_URL will be '/' in client loaded component on dev mode #4973 c733d4fb8 Thanks @bluwy! - Support Astro.slots.render for mdx #4918 a6bb2694b Thanks @bluwy! - Refactor hydration path handling #4977 4f73b98ae Thanks @tony-sull! - Fixes a bug that logged route cache warnings in astro dev #4887 37cb2fc02 Thanks @Calvin-LL! - fix object styles not escaped #4990 8f9791d84 Thanks @matthewp! - Upgrade Astro compiler to 0.26.0 v1.4.4 Compare Source Patch Changes #4967 e6a881081 Thanks @matthewp! - Final perf fix from 1.3.0 regression A regression in rendering perf happened in 1.3.0. This is the final fix for the underlying issue. v1.4.3 Compare Source Patch Changes #4956 ee8dd424f Thanks @matthewp! - Fix perf regression in SSR #4952 5bcd76e3a Thanks @bluwy! - Refactor ViteConfigWithSSR type v1.4.2 Compare Source Patch Changes #4932 9898088c0 Thanks @matthewp! - Prevent hydration mismatch in streaming SSR #4939 cf2bba1e4 Thanks @natemoo-re! - Fix MDX error handling, preventing a memory leak v1.4.1 Compare Source Patch Changes #4928 7690849a8 Thanks @Princesseuh! - Fix module definition of Markdown and MDX files not being available outside Astro files v1.4.0 Compare Source Minor Changes #4907 01c1aaa00 Thanks @matthewp! - Order Astro styles last, to override imported styles This fixes CSS ordering so that imported styles are placed higher than page/component level styles. This means that if you do: delucis/astro-netlify-cms v0.2.3 Compare Source Patch Changes #23 26243d5 Thanks @codelastnight! - remove node join() from vite-plugin-admin-dashboard to allow windows to run dev streetsidesoftware/cspell v6.12.0 Compare Source Features Use cspell-dictionary Module (#3686) (6441f4b) 6.11.1 (2022-09-30) Bug Fixes Fix export of SpellingDictionaryCollection (#3683) (7665cdb) v6.11.1 Compare Source Bug Fixes Fix export of SpellingDictionaryCollection (#3683) (7665cdb) v6.11.0 Compare Source Note: Version bump only for package cspell-monorepo 6.10.1 (2022-09-20) Note: Version bump only for package cspell-monorepo eslint/eslint v8.25.0 Compare Source Features 173e820 feat: Pass --max-warnings value to formatters (#16348) (Brandon Mills) 6964cb1 feat: remove support for ignore files in FlatESLint (#16355) (Milos Djermanovic) 1cc4b3a feat: id-length counts graphemes instead of code units (#16321) (Sosuke Suzuki) Documentation 90c6028 docs: Conflicting fixes (#16366) (Ben Perlmutter) 5a3fe70 docs: Add VS to integrations page (#16381) (Maria José Solano) 49bd1e5 docs: remove unused link definitions (#16376) (Nick Schonning) 3bd380d docs: typo cleanups for docs (#16374) (Nick Schonning) b3a0837 docs: remove duplicate words (#16378) (Nick Schonning) a682562 docs: add BigInt to new-cap docs (#16362) (Sosuke Suzuki) f6d57fb docs: Update docs README (#16352) (Ben Perlmutter) 7214347 docs: fix logical-assignment-operators option typo (#16346) (Jonathan Wilsson) Chores 1f78594 chore: upgrade @eslint/eslintrc@1.3.3 (#16397) (Milos Djermanovic) 8476a9b chore: Remove CODEOWNERS (#16375) (Nick Schonning) 720ff75 chore: use "ci" for Dependabot commit message (#16377) (Nick Schonning) 42f5479 chore: bump actions/stale from 5 to 6 (#16350) (dependabot[bot]) e5e9e27 chore: remove jsdoc dev dependency (#16344) (Milos Djermanovic) ota-meshi/eslint-plugin-astro v0.20.0 Compare Source Minor Changes #116 9c481f8 Thanks @renovate! - update dependency astro-eslint-parser to ^0.7.0 nick-fields/retry v2.8.1 Compare Source Refactor to make testing easier v2.8.0 Compare Source Use spawn rather than exec to support much larger outputs Should resolve #84 and #76 v2.7.1 Compare Source This release contains mostly dependency updates. There are a few very minor changes to runtime code based on development quality of life improvements from newly configured linting and styling. v2.7.0 Compare Source Features retry only on specific exit code (#58) (f227091) Misc Various dependabot updates postcss/postcss v8.4.17 Compare Source Fixed Node.before() unexpected behavior (by Romain Menke). Added TOC to docs (by Mikhail Dedov). withastro/prettier-plugin-astro v0.5.5 Compare Source Patch Changes fe68b94: Fix missing newline after attributes on inline elements when using singleAttributePerLine 96e2b28: Fix expressions not hugging the end of the tag in cases where they should 4e6fde8: Fix newlines being added to style tags even if they were empty umidbekk/prettier-plugin-prisma v4.4.0 Compare Source feat: Bump @prisma/prisma-fmt-wasm to 4.4.0. 7e2fd9a v4.3.0 Compare Source feat: Bump @prisma/prisma-fmt-wasm to 4.3.0. 71f66fe chore: Bump dependencies. d976203 vitejs/vite v3.1.6 Compare Source Please refer to CHANGELOG.md for details. v3.1.5 Compare Source Please refer to CHANGELOG.md for details. Configuration 📅 Schedule: Branch creation - "before 2am" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied. ♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired. If you want to rebase/retry this PR, click this checkbox. This PR has been generated by Mend Renovate. View repository job log here.

Closes actions#481

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://github.com/actions/setup-node) | action | major | `v2.5.2` -> `v4.1.0` | --- ### Release Notes <details> <summary>actions/setup-node (actions/setup-node)</summary> ### [`v4.1.0`](https://github.com/actions/setup-node/releases/tag/v4.1.0) [Compare Source](actions/setup-node@v4.0.4...v4.1.0) #### What's Changed - Resolve High Security Alerts by upgrading Dependencies by [@aparnajyothi-y](https://github.com/aparnajyothi-y) in actions/setup-node#1132 - Upgrade IA Publish by [@Jcambass](https://github.com/Jcambass) in actions/setup-node#1134 - Revise `isGhes` logic by [@jww3](https://github.com/jww3) in actions/setup-node#1148 - Add architecture to cache key by [@pengx17](https://github.com/pengx17) in actions/setup-node#843 This addresses issues with caching by adding the architecture (arch) to the cache key, ensuring that cache keys are accurate to prevent conflicts. Note: This change may break previous cache keys as they will no longer be compatible with the new format. #### New Contributors - [@jww3](https://github.com/jww3) made their first contribution in actions/setup-node#1148 - [@pengx17](https://github.com/pengx17) made their first contribution in actions/setup-node#843 **Full Changelog**: actions/setup-node@v4...v4.1.0 ### [`v4.0.4`](https://github.com/actions/setup-node/releases/tag/v4.0.4) [Compare Source](actions/setup-node@v4.0.3...v4.0.4) #### What's Changed - Add workflow file for publishing releases to immutable action package by [@Jcambass](https://github.com/Jcambass) in actions/setup-node#1125 - Enhance Windows ARM64 Setup and Update micromatch Dependency by [@priyagupta108](https://github.com/priyagupta108) in actions/setup-node#1126 ##### Documentation changes: - Documentation update in the README file by [@suyashgaonkar](https://github.com/suyashgaonkar) in actions/setup-node#1106 - Correct invalid 'lts' version string reference by [@fulldecent](https://github.com/fulldecent) in actions/setup-node#1124 #### New Contributors - [@suyashgaonkar](https://github.com/suyashgaonkar) made their first contribution in actions/setup-node#1106 - [@priyagupta108](https://github.com/priyagupta108) made their first contribution in actions/setup-node#1126 - [@Jcambass](https://github.com/Jcambass) made their first contribution in actions/setup-node#1125 - [@fulldecent](https://github.com/fulldecent) made their first contribution in actions/setup-node#1124 **Full Changelog**: actions/setup-node@v4...v4.0.4 ### [`v4.0.3`](https://github.com/actions/setup-node/releases/tag/v4.0.3) [Compare Source](actions/setup-node@v4.0.2...v4.0.3) #### What's Changed ##### Bug fixes: - Fix macos latest check failures by [@HarithaVattikuti](https://github.com/HarithaVattikuti) in actions/setup-node#1041 ##### Documentation changes: - Documentation update to update default Node version to 20 by [@bengreeley](https://github.com/bengreeley) in actions/setup-node#949 ##### Dependency updates: - Bump undici from 5.26.5 to 5.28.3 by [@dependabot](https://github.com/dependabot) in actions/setup-node#965 - Bump braces from 3.0.2 to 3.0.3 and other dependency updates by [@dependabot](https://github.com/dependabot) in actions/setup-node#1087 #### New Contributors - [@bengreeley](https://github.com/bengreeley) made their first contribution in actions/setup-node#949 - [@HarithaVattikuti](https://github.com/HarithaVattikuti) made their first contribution in actions/setup-node#1041 **Full Changelog**: actions/setup-node@v4...v4.0.3 ### [`v4.0.2`](https://github.com/actions/setup-node/releases/tag/v4.0.2) [Compare Source](actions/setup-node@v4.0.1...v4.0.2) #### What's Changed - Add support for `volta.extends` by [@ThisIsManta](https://github.com/ThisIsManta) in actions/setup-node#921 - Add support for arm64 Windows by [@dmitry-shibanov](https://github.com/dmitry-shibanov) in actions/setup-node#927 #### New Contributors - [@ThisIsManta](https://github.com/ThisIsManta) made their first contribution in actions/setup-node#921 **Full Changelog**: actions/setup-node@v4.0.1...v4.0.2 ### [`v4.0.1`](https://github.com/actions/setup-node/releases/tag/v4.0.1) [Compare Source](actions/setup-node@v4.0.0...v4.0.1) #### What's Changed - Ignore engines in Yarn 1 e2e-cache tests by [@trivikr](https://github.com/trivikr) in actions/setup-node#882 - Update setup-node references in the README.md file to setup-node@v4 by [@jwetzell](https://github.com/jwetzell) in actions/setup-node#884 - Update reusable workflows to use Node.js v20 by [@MaksimZhukov](https://github.com/MaksimZhukov) in actions/setup-node#889 - Add fix for cache to resolve slow post action step by [@aparnajyothi-y](https://github.com/aparnajyothi-y) in actions/setup-node#917 - Fix README.md by [@takayamaki](https://github.com/takayamaki) in actions/setup-node#898 - Add `package.json` to `node-version-file` list of examples. by [@TWiStErRob](https://github.com/TWiStErRob) in actions/setup-node#879 - Fix node-version-file interprets entire package.json as a version by [@NullVoxPopuli](https://github.com/NullVoxPopuli) in actions/setup-node#865 #### New Contributors - [@trivikr](https://github.com/trivikr) made their first contribution in actions/setup-node#882 - [@jwetzell](https://github.com/jwetzell) made their first contribution in actions/setup-node#884 - [@aparnajyothi-y](https://github.com/aparnajyothi-y) made their first contribution in actions/setup-node#917 - [@takayamaki](https://github.com/takayamaki) made their first contribution in actions/setup-node#898 - [@TWiStErRob](https://github.com/TWiStErRob) made their first contribution in actions/setup-node#879 - [@NullVoxPopuli](https://github.com/NullVoxPopuli) made their first contribution in actions/setup-node#865 **Full Changelog**: actions/setup-node@v4...v4.0.1 ### [`v4.0.0`](https://github.com/actions/setup-node/releases/tag/v4.0.0) [Compare Source](actions/setup-node@v3.8.2...v4.0.0) #### What's Changed In scope of this release we changed version of node runtime for action from node16 to node20 and updated dependencies in actions/setup-node#866 Besides, release contains such changes as: - Upgrade actions/checkout to v4 by [@gmembre-zenika](https://github.com/gmembre-zenika) in actions/setup-node#868 - Update actions/checkout for documentation and yaml by [@dmitry-shibanov](https://github.com/dmitry-shibanov) in actions/setup-node#876 #### New Contributors - [@gmembre-zenika](https://github.com/gmembre-zenika) made their first contribution in actions/setup-node#868 **Full Changelog**: actions/setup-node@v3...v4.0.0 ### [`v3.8.2`](https://github.com/actions/setup-node/releases/tag/v3.8.2) [Compare Source](actions/setup-node@v3.8.1...v3.8.2) #### What's Changed - Update semver by [@dmitry-shibanov](https://github.com/dmitry-shibanov) in actions/setup-node#861 - Update temp directory creation by [@nikolai-laevskii](https://github.com/nikolai-laevskii) in actions/setup-node#859 - Bump [@babel/traverse](https://github.com/babel/traverse) from 7.15.4 to 7.23.2 by [@dependabot](https://github.com/dependabot) in actions/setup-node#870 - Add notice about binaries not being updated yet by [@nikolai-laevskii](https://github.com/nikolai-laevskii) in actions/setup-node#872 - Update toolkit cache and core by [@dmitry-shibanov](https://github.com/dmitry-shibanov) and [@seongwon-privatenote](https://github.com/seongwon-privatenote) in actions/setup-node#875 **Full Changelog**: actions/setup-node@v3...v3.8.2 ### [`v3.8.1`](https://github.com/actions/setup-node/releases/tag/v3.8.1) [Compare Source](actions/setup-node@v3.8.0...v3.8.1) #### What's Changed In scope of this release, the filter was removed within the cache-save step by [@dmitry-shibanov](https://github.com/dmitry-shibanov) in actions/setup-node#831. It is filtered and checked in the toolkit/cache library. **Full Changelog**: actions/setup-node@v3...v3.8.1 ### [`v3.8.0`](https://github.com/actions/setup-node/releases/tag/v3.8.0) [Compare Source](actions/setup-node@v3.7.0...v3.8.0) #### What's Changed ##### Bug fixes: - Add check for existing paths by [@dmitry-shibanov](https://github.com/dmitry-shibanov) in actions/setup-node#803 - Resolve SymbolicLink by [@dmitry-shibanov](https://github.com/dmitry-shibanov) in actions/setup-node#809 - Change passing logic for cache input by [@dmitry-shibanov](https://github.com/dmitry-shibanov) in actions/setup-node#816 - Fix armv7 cache issue by [@louislam](https://github.com/louislam) in actions/setup-node#794 - Update check-dist workflow name by [@sinchang](https://github.com/sinchang) in actions/setup-node#710 ##### Feature implementations: - feat: handling the case where "node" is used for tool-versions file. by [@xytis](https://github.com/xytis) in actions/setup-node#812 ##### Documentation changes: - Refer to semver package name in README.md by [@olleolleolle](https://github.com/olleolleolle) in actions/setup-node#808 ##### Update dependencies: - Update toolkit cache to fix zstd by [@dmitry-shibanov](https://github.com/dmitry-shibanov) in actions/setup-node#804 - Bump tough-cookie and [@azure/ms-rest-js](https://github.com/azure/ms-rest-js) by [@dependabot](https://github.com/dependabot) in actions/setup-node#802 - Bump semver from 6.1.2 to 6.3.1 by [@dependabot](https://github.com/dependabot) in actions/setup-node#807 - Bump word-wrap from 1.2.3 to 1.2.4 by [@dependabot](https://github.com/dependabot) in actions/setup-node#815 #### New Contributors - [@olleolleolle](https://github.com/olleolleolle) made their first contribution in actions/setup-node#808 - [@louislam](https://github.com/louislam) made their first contribution in actions/setup-node#794 - [@sinchang](https://github.com/sinchang) made their first contribution in actions/setup-node#710 - [@xytis](https://github.com/xytis) made their first contribution in actions/setup-node#812 **Full Changelog**: actions/setup-node@v3...v3.8.0 ### [`v3.7.0`](https://github.com/actions/setup-node/releases/tag/v3.7.0) [Compare Source](actions/setup-node@v3.6.0...v3.7.0) #### What's Changed In scope of this release we added a logic to save an additional cache path for yarn 3 ([related pull request](actions/setup-node#744) and [feature request](actions/setup-node#325)). Moreover, we added functionality to use all the sub directories derived from `cache-dependency-path` input and add detect all dependencies directories to cache (related [pull request](actions/setup-node#735) and [feature request](actions/setup-node#488)). ##### Besides, we made such changes as: - Replace workflow badge with new badge by [@jongwooo](https://github.com/jongwooo) in actions/setup-node#653 - Fix a minor typo by [@phanan](https://github.com/phanan) in actions/setup-node#662 - docs: fix typo in advanced-usage.md by [@remarkablemark](https://github.com/remarkablemark) in actions/setup-node#697 - bugfix: Don't attempt to use Windows fallbacks on non-Windows OSes by [@domdomegg](https://github.com/domdomegg) in actions/setup-node#718 - Update to node 18.x by [@feelepxyz](https://github.com/feelepxyz) in actions/setup-node#751 - Remove implicit dependencies by [@nikolai-laevskii](https://github.com/nikolai-laevskii) in actions/setup-node#758 - Fix description about ensuring workflow access to private package by [@x86chi](https://github.com/x86chi) in actions/setup-node#704 #### New Contributors - [@jongwooo](https://github.com/jongwooo) made their first contribution in actions/setup-node#653 - [@phanan](https://github.com/phanan) made their first contribution in actions/setup-node#662 - [@remarkablemark](https://github.com/remarkablemark) made their first contribution in actions/setup-node#697 - [@domdomegg](https://github.com/domdomegg) made their first contribution in actions/setup-node#718 - [@feelepxyz](https://github.com/feelepxyz) made their first contribution in actions/setup-node#751 - [@nikolai-laevskii](https://github.com/nikolai-laevskii) made their first contribution in actions/setup-node#758 - [@x86chi](https://github.com/x86chi) made their first contribution in actions/setup-node#704 **Full Changelog**: actions/setup-node@v3...v3.7.0 ### [`v3.6.0`](https://github.com/actions/setup-node/releases/tag/v3.6.0): Add Support for Nightly, Canary and RC builds for Node.js [Compare Source](actions/setup-node@v3.5.1...v3.6.0) In scope of this release we added support to download nightly, rc (actions/setup-node#611) and canary (actions/setup-node#619) Node.js distributions. ##### For nightly versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-nightly' - run: npm ci - run: npm test ``` ##### For canary versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16-v8-canary’ - run: npm ci - run: npm test ``` ##### For rc versions: ```yaml jobs: build: runs-on: ubuntu-latest name: Node sample steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: '16.0.0-rc.1’ - run: npm ci - run: npm test ``` Note: For more examples please refer to [documentation](https://github.com/actions/setup-node#advanced-usage). Besides, we added the following changes as: - Updated minimatch: actions/setup-node#608 - Fixed extra newline character in version output when reading from a file: actions/setup-node#625 - Passed the token input through on GHES: actions/setup-node#595 - Fixed issue with scoped registries are duplicated in npmrc: actions/setup-node#637 ### [`v3.5.1`](https://github.com/actions/setup-node/releases/tag/v3.5.1): Update @actions/core and Print Node, Npm, Yarn versions [Compare Source](actions/setup-node@v3.5.0...v3.5.1) In scope of this release we updated [actions/core to 1.10.0](actions/setup-node#587). Moreover, we added logic [to print Nodejs, Npm, Yarn versions](actions/setup-node#368) after installation. ### [`v3.5.0`](https://github.com/actions/setup-node/releases/tag/v3.5.0): Add support for engines.node and Volta [Compare Source](actions/setup-node@v3.4.1...v3.5.0) In scope of this release we add support for engines.node. The action will be able to grab the version form package.json#engines.node. actions/setup-node#485. Moreover, we [added support for Volta](actions/setup-node#532) Besides, we updated [@actions/core to 1.9.1](actions/setup-node#574) and [@actions/cache to 3.0.4](actions/setup-node#573) ### [`v3.4.1`](https://github.com/actions/setup-node/releases/tag/v3.4.1): Fix pnpm output and node-version output issues [Compare Source](actions/setup-node@v3.4.0...v3.4.1) In scope of this release we fixed bugs related to the pnpm 7.5.1 output issue from `pnpm store path` actions/setup-node#545. Moreover we fixed the issue with falling on node-version output actions/setup-node#540. ### [`v3.4.0`](https://github.com/actions/setup-node/releases/tag/v3.4.0): Add support for asdf format and update actions/cache version to 3.0.0 [Compare Source](actions/setup-node@v3.3.0...v3.4.0) In scope of this release we updated `actions/cache` package as the new version contains fixes for [caching error handling](actions/setup-node#526). Moreover, we added support for asdf format as Node.js version file actions/setup-node#373. Besides, we introduced new output [node-version](actions/setup-node#534) and added `npm-shrinkwrap.json` to dependency file patterns: actions/setup-node#439 ### [`v3.3.0`](https://github.com/actions/setup-node/releases/tag/v3.3.0): Add support for lts/-n aliases [Compare Source](actions/setup-node@v3.2.0...v3.3.0) In scope of this release we added support for `lts/-n` aliases, improve logic for `current`, `latest` and `node` aliases to handle them from `toolcache`, update `ncc` package. ##### Support of lts/-n aliases - Related pull request: actions/setup-node#481 - Related issue: actions/setup-node#26 ```yaml steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: lts/-1 - run: npm ci - run: npm test ``` ##### Minor improvements - Update zeit/ncc to vercel/ncc: actions/setup-node#476 - Get latest version from cache if exists: actions/setup-node#496 ### [`v3.2.0`](https://github.com/actions/setup-node/releases/tag/v3.2.0): Add current, node, latest aliases [Compare Source](actions/setup-node@v3.1.1...v3.2.0) In scope of this release we added new aliases to install the latest Node.js version. actions/setup-node#483 ```yml steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: current - run: npm ci - run: npm test ``` ### [`v3.1.1`](https://github.com/actions/setup-node/releases/tag/v3.1.1): Update actions/cache version to 2.0.2 [Compare Source](actions/setup-node@v3.1.0...v3.1.1) In scope of this release we updated `actions/cache` package as the new version contains fixes related to GHES 3.5 (actions/setup-node#460) ### [`v3.1.0`](https://github.com/actions/setup-node/releases/tag/v3.1.0): Add caching support on GHES 3.5 [Compare Source](actions/setup-node@v3.0.0...v3.1.0) In scope of this release we added [support for caching from GHES 3.5](actions/setup-node#452) and fixed download issue for files > 2GB during restore. Besides, we updated `actions/cache` dependency to 2.0.0 version. ### [`v3.0.0`](https://github.com/actions/setup-node/releases/tag/v3.0.0) [Compare Source](actions/setup-node@v2.5.2...v3.0.0) In scope of this release we changed version of the runtime Node.js for the setup-node action and updated package-lock.json file to v2. ##### Breaking Changes - With the update to Node 16 in actions/setup-node#414, all scripts will now be run with Node 16 rather than Node 12. - We removed deprecated `version` input (actions/setup-node#424). Please use `node-version` input instead. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.bruyant.xyz/alexandre/PaletteSwitcher/pulls/56 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>

jablko requested a review from a team May 2, 2022 20:01

jablko force-pushed the patch-1 branch from 2bb90ac to d00b893 Compare May 6, 2022 14:17

jablko force-pushed the patch-1 branch 2 times, most recently from 2358e7c to 7ababba Compare May 10, 2022 19:56

jablko force-pushed the patch-1 branch from 7ababba to d1c420e Compare May 13, 2022 23:14

dmitry-shibanov approved these changes May 16, 2022

View reviewed changes

marko-zivic-93 approved these changes May 16, 2022

View reviewed changes

jablko added 4 commits May 30, 2022 10:21

Support lts/-n aliases

0ae8776

Add e2e test

e884a30

Fix e2e test

db5bd66

Combine LTS tests with it.each(table)

c4f9da0

jablko force-pushed the patch-1 branch from d1c420e to c4f9da0 Compare May 30, 2022 17:28

Don't reverse the manifest

e8fa6b0

dmitry-shibanov approved these changes May 31, 2022

View reviewed changes

marko-zivic-93 approved these changes May 31, 2022

View reviewed changes

IvanZosimov approved these changes May 31, 2022

View reviewed changes

tooomm mentioned this pull request Jun 1, 2022

Support aliases like LTS #26

Closed

dmitry-shibanov merged commit eeb10cf into actions:main Jun 2, 2022

This was referenced Jun 7, 2022

build(deps): bump actions/setup-node from 3.2.0 to 3.3.0 website-local/mdn-local#599

Merged

build(deps): bump actions/setup-node from 3.2.0 to 3.3.0 website-local/scraper-misc#99

Merged

callree reviewed Jun 24, 2022

View reviewed changes

amclin mentioned this pull request Jul 8, 2022

lts/ named aliases not resolving to correct sequence of versions #536

Closed

5 tasks

myfreeer mentioned this pull request Oct 11, 2022

build(deps): bump actions/setup-node from 3.2.0 to 3.3.0 website-local/website-scrap-engine#562

Merged

stephanprantl mentioned this pull request Oct 11, 2022

Bump actions/setup-node from 3.2.0 to 3.3.0 wrk-tafel/admin#216

Merged

nelsonni mentioned this pull request Oct 14, 2022

Bump setup-node GitHub Action to v3 EPICLab/synectic#971

Closed

nelsonni mentioned this pull request Dec 7, 2022

Bump actions/setup-node from v2 to v3 EPICLab/synectic#1031

Merged

deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023

docs(README): fix wording

cb04122

Closes actions#481

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support lts/-n aliases #481

Support lts/-n aliases #481

jablko commented May 2, 2022 •

edited

Loading

e-korolevskii commented May 6, 2022

jablko commented May 6, 2022

dmitry-shibanov commented May 10, 2022

jablko commented May 10, 2022

jablko commented May 10, 2022

jablko commented May 13, 2022

dmitry-shibanov commented May 30, 2022

jablko commented May 30, 2022

dmitry-shibanov commented May 30, 2022

jablko commented May 30, 2022

callree left a comment

Support lts/-n aliases #481

Support lts/-n aliases #481

Conversation

jablko commented May 2, 2022 • edited Loading

e-korolevskii commented May 6, 2022

jablko commented May 6, 2022

dmitry-shibanov commented May 10, 2022

jablko commented May 10, 2022

jablko commented May 10, 2022

jablko commented May 13, 2022

dmitry-shibanov commented May 30, 2022

jablko commented May 30, 2022

dmitry-shibanov commented May 30, 2022

jablko commented May 30, 2022

callree left a comment

Choose a reason for hiding this comment

jablko commented May 2, 2022 •

edited

Loading