Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only execute post for actions that have one #1481

Merged
merged 6 commits into from
Nov 18, 2021

Conversation

fhammerl
Copy link
Contributor

@fhammerl fhammerl commented Nov 12, 2021

Fixes #1460

@fhammerl fhammerl marked this pull request as ready for review November 15, 2021 14:55
@fhammerl fhammerl requested a review from a team as a code owner November 15, 2021 14:55
_cachedEmbeddedPostSteps[parentStepId].Push(clonedAction);
// if we're in a composite action and haven't loaded the local action yet
// we assume it has a post step
if (!_cachedEmbeddedPostSteps.ContainsKey(parentStepId))
Copy link
Collaborator

@thboop thboop Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the spacing here got messed up, we should revert

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fhammerl fhammerl merged commit 4dc8a09 into main Nov 18, 2021
@fhammerl fhammerl deleted the fhammerl/fix-nested-node-post branch November 18, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Run: Error: Value cannot be null. (Parameter 'target')
2 participants