Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept namespace as array #258

Merged
merged 1 commit into from
Jul 31, 2018
Merged

accept namespace as array #258

merged 1 commit into from
Jul 31, 2018

Conversation

witem
Copy link
Contributor

@witem witem commented Jul 25, 2018

Base on proposal: #245 (comment)


Description updated by @evantahler

When choosing a namespace for your Resque connection (queue, worker, or scheduler), the namespace option can now be an array, ie ['my', 'namespace'] which would resolve to my:namespace in redis.

@witem
Copy link
Contributor Author

witem commented Jul 31, 2018

@evantahler what you think about this PR?

@evantahler
Copy link
Member

👍

@evantahler evantahler merged commit 6b7fb40 into actionhero:master Jul 31, 2018
@evantahler
Copy link
Member

Released https://github.com/taskrabbit/node-resque/releases/tag/v5.4.1

@glensc
Copy link
Contributor

glensc commented Sep 10, 2020

Why is this useful? what problem does it solve? the link in PR body does not give any idea of array usefulness.

@witem
Copy link
Contributor Author

witem commented Sep 10, 2020

Why is this useful? what problem does it solve? the link in PR body does not give any idea of array usefulness.

This allows you to flexibly customize namespace for different environments without unnecessary string transformations. In my example it allows flexibly config namespace in ActionHero

@witem witem deleted the ISS-245 branch September 16, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants