Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ES2025 RegExp duplicate named capturing groups #1291

Closed
wants to merge 5 commits into from
Closed

Add support for ES2025 RegExp duplicate named capturing groups #1291

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f03e191
Add support for ES2025 RegExp Duplicate named capturing groups
ota-meshi Apr 14, 2024
f7a9609
add test case
ota-meshi Apr 15, 2024
971bcff
refactor
ota-meshi Apr 15, 2024
589b298
fix comment
ota-meshi Apr 15, 2024
d376f70
fix comment
ota-meshi Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix comment
  • Loading branch information
@ota-meshi
ota-meshi committed Apr 15, 2024
commit d376f70558f15a9bbae0b2fbc1dd193cd488a42a
2 changes: 1 addition & 1 deletion acorn/src/regexp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ pp.regexp_alternative = function(state) {
state.groupNamesToAddToUpperScope.push(groupName)
}
}
// Reverts the groupNames so that the next adjacent Alt does not report duplicates.
// Reverts the groupNames so that the next adjacent Alternative does not report duplicates.
state.groupNames = upperGroupNames
}
}
Expand Down
Loading