Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper .d.mts extension for .mjs types #1211

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

Andarist
Copy link
Contributor

It's likely that .mjs.d.ts was also working but the "official" extension for declaration files targeting .mjs files is .d.mts. I hope that this will fix the issues reported by: https://arethetypeswrong.github.io/?p=acorn%408.8.2 . acorn has been listed as a popular misconfigured package here

@marijnh marijnh merged commit 3ef09ce into acornjs:master Apr 29, 2023
@Andarist Andarist deleted the use-propert-extension branch April 29, 2023 14:20
@Andarist
Copy link
Contributor Author

@marijnh note that there might be still some issues with those new moduleResolution options in TS. I will try to remember to recheck how things are with this fix once you release this to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants