-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue_tracker] Add Batch Mode #9339
base: main
Are you sure you want to change the base?
Conversation
Great start Ayush! Could you please embed here (or else link) the video, or screenshots are fine. For the missing modal - could this be fixed before this work is presented to the larger team at the end of September, to avoid confusion and so Debug mode can be fully useful --: The reason why --: @racostas @regisoc let me know asap if this has already been discussed among you. Thanks Ayush, it's looking solid otherwise. |
Hi @ay-bh, I reviewed the PR and is looking like a good start indeed. |
@SantiagoTG, your inputs here are also very welcome since you have been working a loot with issue tracker. If you have time to take a look to this proposal you opinion is very important. Thanks. |
@racostas @ay-bh to keep you updated, we did not have time to test that together with @SantiagoTG. |
Hello @ay-bh great start indeed! Here are some comments from both me and @SantiagoTG. I tried to group comments:
That was a lot more to write than expected, but I tried to describe each point. |
Hi @regisoc, very good review in facts. I'm sure @ay-bh can address all of this points before the end of the coding period (end of October). Maybe he can present some of the advances he had been making in two weeks from now. (then do a second final presentation in November 5). I will keep you posted with more details after consulting it with him because he have other commitments in the school as well. |
Can we also make sure this has a more descriptive name than "Debug View"? I suggest something like "Batch Mode" since that seems to be what it's doing. |
Thank you all for your detailed feedback and suggestions. I'll start working on implementing these improvements. |
Hi @ay-bh, this two changes are looking good. Thanks for the update ! Great work ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ay-bh, very nice work !
I have been testing the new modifications and they look great.
I have a couple of comments nevertheless we can address:
- I think pagination at the end of the cards will be very useful, right now we have it in the top, can we have it on both (top and bottom) ? This way the user don't have to go to the beginning of the page to go to the next pages or to change the quantity of cards it wants to consult if changes it mind when arriving at the end of the page
- Also regarding pagination, by default we start at 20 in most of the LORIS modules, but since the design of this one is particular and the cards to take more screen area I think we can start in 10 as an option for the user. What do yo think ?
- I like very much the way you had addressed how to show the comments inside the card ( very nice ). Do you think it will be possible to add a button, or link to show all the comments ? ( this will help the user to decide in long living issues without having to go to the standard view to see all of then)
Again @ay-bh, very good progress !! Looking forward for the new features !!
Great progress @ay-bh - looking forward to seeing this presented. Just to check the outstanding permission for |
@ay-bh I will try to do another review before the end of the week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add with @racostas previous review:
- pagination change at the bottom.
- pagination starts at 10 (yes!).
- link to all comments. Could be nice, but I think this one is less a priority. All comments can be accessed by clicking the issue ID/title for the full issue view.
Points to be addressed (previous review):
- issues pagination: looks ok, but do not have enough issues to test. Maybe easier to test with a pagination at 10 ;)
- issues ordering. Not a priority.
- bug: issue timestamp not updating: resolved.
- display last comments: looks nice!
- clearer disabled elements: if possible, change dropdown to a label when it is disabled + add the actual label (category,priority,status). i.e. seomthing like
category: aaa
. - new modal for comments: partially done. Still needs to modify assigned/watchers but it looks simple and great. Tested with 5 paragraphs of lorem ipsum and still looks nice!
- filter block: more genral comment here. The actual design is better but we still cannot track how many filters are selected. I was more thinking about something like this where: we can direct access to all filter in one click, have a visual hint on which filters have selected criteria (badge/number), and collapse the full filter section to focus on issues.
- bug: issue with description text area: ok.
- filter reset button.
- Site filters.
Brief summary of changes
"Debug View""Batch Mode" in Issue Tracker moduleThe following features will be implemented in a future PR:
issue_tracker_debug_mode_edit
Testing instructions (if applicable)
Link(s) to related issue(s)
Demo
Demo.mov