Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dataquery/instruments] Handle cardinality::many instruments in DQT #9305

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Jul 2, 2024

The ability for the frontend to display session variables with a cardinality of "many" per session was added for the imaging, but the instrument queryengine backend was not updated to properly format multi-select elements. This adds support for multiselect elements by updating the instrument queryengine to return correctly formatted data for instruments with the many cardinality.

The ability for the frontend to display session variables with a cardinality
of "many" per session was added for the imaging, but the instrument queryengine
was not updated to properly format multi-select elements. This adds support
for multiselect elements by updating the instrument queryengine to return
correctly formatted data for instruments.
@driusan driusan added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Jul 2, 2024
@driusan driusan added the Critical to release PR or issue is key for the release to which it has been assigned label Sep 24, 2024
@cmadjar
Copy link
Collaborator

cmadjar commented Oct 1, 2024

@GeorgeMurad could you please review and test this PR? Thank you!

Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 32377a2 into aces:26.0-release Oct 3, 2024
28 checks passed
HenriRabalais pushed a commit to HenriRabalais/Loris that referenced this pull request Oct 10, 2024
…ces#9305)

The ability for the frontend to display session variables with a
cardinality of "many" per session was added for the imaging, but the
instrument queryengine backend was not updated to properly format
multi-select elements. This adds support for multiselect elements by
updating the instrument queryengine to return correctly formatted data
for instruments with the many cardinality.
HenriRabalais pushed a commit to HenriRabalais/Loris that referenced this pull request Oct 10, 2024
…ces#9305)

The ability for the frontend to display session variables with a
cardinality of "many" per session was added for the imaging, but the
instrument queryengine backend was not updated to properly format
multi-select elements. This adds support for multiselect elements by
updating the instrument queryengine to return correctly formatted data
for instruments with the many cardinality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Critical to release PR or issue is key for the release to which it has been assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants