Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Accounts] Site as multi select #9022

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

sruthymathew123
Copy link
Contributor

Brief summary of changes

Testing instructions (if applicable)

Link(s) to related issue(s)

@sruthymathew123 sruthymathew123 changed the title Site as multi select [User Accounts] Site as multi select Jan 26, 2024
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working correctly.

I am getting results in my data table when selecting a superset of the results' sites, for example.

@driusan
Copy link
Collaborator

driusan commented Feb 6, 2024

@jeffersoncasimir Isn't that expected? I would think selecting multiple values in a multiselect filter would mean if it's any of those, include the result.

@jeffersoncasimir
Copy link
Contributor

My mistake, I thought it behaved like an AND.
In that case, it works as expected!

@driusan driusan merged commit 4ce82e1 into aces:main Feb 13, 2024
19 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[user_accounts] Convert site dropbox filter from select to multiselect
4 participants