Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[candidate_list] Multiselect for visit label, site, and cohort #8730

Conversation

charlottesce
Copy link
Contributor

Brief summary of changes

The filters for site, cohort and visit label are now multiselect

Testing instructions (if applicable)

  1. Go to Candidate -> Access Profiles page
  2. Check that you can select multiple visit labels, cohorts, and visits

Note

This is a CCNA override - https://github.com/aces/CCNA/pull/3922

@driusan
Copy link
Collaborator

driusan commented Jun 7, 2023

This makes sense to me.. @racostas could you review/test?

@racostas racostas self-requested a review July 3, 2023 15:15
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There is a small typo in the description of the PR but all fine
in place of:
2. Check that you can select multiple visit labels, cohorts, and visits
Should be;
2. Check that you can select multiple visit labels, cohorts, and sites

Should this one go to 25 @driusan ?

@racostas racostas added the Passed Manual Tests PR has undergone proper testing by at least one peer label Jul 3, 2023
@driusan driusan merged commit 211aa63 into aces:main Aug 8, 2023
12 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants