Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] fix the test error in main branch #7554

Merged
merged 9 commits into from
Aug 31, 2021

Conversation

kongtiaowang
Copy link
Contributor

Brief summary of changes

  • Have you updated related documentation?

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@kongtiaowang kongtiaowang changed the title debug only [Travis] fix the test error in main branch Aug 27, 2021
@driusan driusan mentioned this pull request Aug 27, 2021
4 tasks
@ridz1208
Copy link
Collaborator

@kongtiaowang failing tests ironically

@xlecours
Copy link
Contributor

@kongtiaowang Do we know why 7 rows was passing last week and now we need to look for 6 ?

@kongtiaowang
Copy link
Contributor Author

@xlecours The "7 rows " got merged 4 days ago, after that Travis still failed. It didn't pass Travis. I have tested it on Loris from 21 to main. " 6 rows " is correct.
Screen Shot 2021-08-30 at 2 04 33 PM

@driusan
Copy link
Collaborator

driusan commented Aug 30, 2021

do you have a link to the PR that the 7->6 was merged in?

@AlexandraLivadas
Copy link
Contributor

@driusan The PR was #7318

@driusan driusan merged commit 7c3b88e into aces:main Aug 31, 2021
@ridz1208 ridz1208 added this to the 24.0.0 milestone Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants