[User Accounts] Permissions panel fix

[AlexandraLivadas]

The permissions panel on the edit user page is not correctly displaying Permission descriptions for user's with superuser permission. This is because of a superuser permissions check which returned a list of permissions without a label parameter specified.

View before:

View after:

Testing instructions (if applicable)

1. Go to edit a user as a superuser and check that the permissions are correctly displayed with their descriptions
2. Verify that the permissions are also displayed correctly for a user who is not a superuser

• Resolves [User accounts] Permission panel issue #7437
• Related to [User Accounts] Superuser: add user permission fix #6770

[laemtl]

@AlexandraLivadas Tests are failing.

1) UserTest::testGetPermissionsVerbose
PDOStatement::execute(): SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens

/app/php/libraries/Database.class.inc:708
/app/php/libraries/Database.class.inc:745
/app/php/libraries/UserPermissions.class.inc:312
/app/test/unittests/UserTest.php:1127

[AlexandraLivadas]

@laemtl The tests seem to be passing fine on my sandbox so I will re-run Travis. If it still is failing, I will debug :)

[christinerogers]

Tests failing, @AlexandraLivadas

[ridz1208]

@AlexandraLivadas any news on this? do you need help with the tests ?

[AlexandraLivadas]

@laemtl @kongtiaowang This is ready for review

[laemtl]

Why not using hasPermission('superuser')?

[AlexandraLivadas]

I will checkout this branch and make sure there was a reason for this decision :)

[laemtl]

I think this line should be:
if (!$this->hasPermission('superuser')) {
Then your new test case should start working again. You can try to add it back. Thanks!