Medical - Fix script error when bandaging #9956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnb432
previously requested changes
Apr 19, 2024
LinkIsGrim
requested changes
Apr 19, 2024
There was a problem hiding this comment.
need to update docs @https://github.com/acemod/ACE3/blob/master/docs/wiki/framework/events-framework.md?plain=1#L45
can do so myself.
changelog/release might want to mention we're breaking API for bugfix? I don't think anyone actually uses this yet though
Co-authored-by: Grim <[email protected]>
Doesn't hurt, but docs were outdated even before this issue, so idk how much it will help. |
LinkIsGrim
approved these changes
Apr 19, 2024
Krzyciu
added a commit
to Arma4Ever/A4ES_A3
that referenced
this pull request
Apr 20, 2024
acemod/ACE3#9956 Update CBA Settings Change mod logo
SzwedzikPL
pushed a commit
to Arma4Ever/A4ES_A3
that referenced
this pull request
Apr 20, 2024
acemod/ACE3#9956 Update CBA Settings Change mod logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
overwrite the value of createLitter set by treatment to 1 for bandage effectivenesschange bandage effectiveness to not use the same args index as createLitter.I could not see where an actual value for bandage effectiveness was being passed through, so could also remove this value and its usages entirelyIMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.