Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hearing - Add setting to add earplugs to all units #9935

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 7, 2024

When merged this pull request will:

  • Title. I took the existing setting and converted it to a list, but we could make a new setting if wanted.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Apr 7, 2024
@LinkIsGrim LinkIsGrim added kind/setting Release Notes: **SETTINGS:** and removed kind/enhancement Release Notes: **IMPROVED:** labels Apr 8, 2024
@LinkIsGrim LinkIsGrim added this to the 3.17.1 milestone Apr 10, 2024
@LinkIsGrim LinkIsGrim merged commit 5130a22 into master Apr 10, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the hearing-add-earplugs-everyone branch April 10, 2024 11:23
@jonpas
Copy link
Member

jonpas commented Apr 26, 2024

For reference, people setting this with boolean as old value in their cba_settings.sqf will see:

21:08:02 [CBA] (settings) WARNING: Invalid value false for setting ace_hearing_autoAddEarplugsToUnits. Fall back to default value.

Until they update it with the new value.


I am not sure if this is intended by CBA, boolean is converted appropriately anyways.

@johnb432
Copy link
Contributor Author

I knew that the warning would pop up in the RPT, but I wasn't sure how it would be handled. I thought it would revert to the default value, which imo would have been fine.

@jonpas
Copy link
Member

jonpas commented Apr 26, 2024

It does go back to default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/setting Release Notes: **SETTINGS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants